Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish turbopack start logging #57203

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Polish turbopack start logging #57203

merged 8 commits into from
Oct 23, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 22, 2023

Bring a tiny util to get a (turbo) label after next.js info for turbopack dev-server logging and also remove the disclaimer of "thank you for trying".

After

image

Before

image
  • Fixes the bad dim color
  • Colorize the Next.js (turbo) label
  • Move the learning link down after start message
  • Use Log util to format logs
  • Remove "v13" related text

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 22, 2023
@ijjk
Copy link
Member

ijjk commented Oct 22, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 22, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
buildDuration 10.2s 10.2s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 174 MB 174 MB N/A
nextStartRea..uration (ms) 500ms 495ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
199-HASH.js gzip 27.6 kB 27.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 252 B 252 B
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
index.html gzip 530 B 529 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js turbo-remove-disclimar Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: 377d242

@shuding
Copy link
Member

shuding commented Oct 22, 2023

Colorize the Next.js (turbo) label

I think it feels lacking of contrast on that gray CLI background.

@huozhi
Copy link
Member Author

huozhi commented Oct 23, 2023

@shuding I simplfied it to leverage the same styling of the banner

@huozhi huozhi marked this pull request as ready for review October 23, 2023 01:12
@huozhi huozhi force-pushed the turbo-remove-disclimar branch from e7a624f to 3a40645 Compare October 23, 2023 01:16
@huozhi huozhi force-pushed the turbo-remove-disclimar branch from 3a40645 to 384c2c6 Compare October 23, 2023 01:17
@kodiakhq kodiakhq bot merged commit c520775 into canary Oct 23, 2023
55 of 59 checks passed
@kodiakhq kodiakhq bot deleted the turbo-remove-disclimar branch October 23, 2023 02:53
@github-actions github-actions bot added the locked label Nov 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants