Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __nextjs_pure helper #57286

Merged
merged 18 commits into from
Oct 23, 2023
Merged

Add __nextjs_pure helper #57286

merged 18 commits into from
Oct 23, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 23, 2023

What?

Safely drop __nextjs_pure from next internals in transform

import {__nextjs_pure} from 'next/dist/build/swc/helpers'

__nextjs_pure(console.log("test!"))

becomes

/*#__PURE__*/ console.log("test!");

so it will be dropped by the minifier - terser and swc minifier will both work.

Why?

Adding pure comments from JS world with swc transform is complex. This would be a helper for the case if we want to create "pure" expressions.

How?

Closes WEB-1829

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. type: next labels Oct 23, 2023
@kdy1 kdy1 marked this pull request as ready for review October 23, 2023 19:42
@kdy1 kdy1 requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners October 23, 2023 19:42
@huozhi huozhi marked this pull request as draft October 23, 2023 19:48
@huozhi huozhi changed the title feat: Add markAsPure to @next/magic (wip) Add __nextjs_pure helper Oct 23, 2023
@huozhi huozhi changed the title (wip) Add __nextjs_pure helper Add __nextjs_pure helper Oct 23, 2023
@huozhi huozhi marked this pull request as ready for review October 23, 2023 23:10
huozhi
huozhi previously approved these changes Oct 23, 2023
@ijjk
Copy link
Member

ijjk commented Oct 23, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
buildDuration 10.4s 10.5s ⚠️ +118ms
buildDurationCached 6.1s 6s N/A
nodeModulesSize 177 MB 177 MB ⚠️ +1.54 kB
nextStartRea..uration (ms) 414ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
199-HASH.js gzip 27.9 kB 27.9 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
index.html gzip 528 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 157 kB 158 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-pure Change
middleware-b..fest.js gzip 625 B 624 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 5ec7468

@ijjk
Copy link
Member

ijjk commented Oct 23, 2023

Tests Passed

@shuding shuding merged commit 4bbf9b6 into canary Oct 23, 2023
53 of 58 checks passed
@shuding shuding deleted the kdy1/swc-pure branch October 23, 2023 23:44
ijjk added a commit that referenced this pull request Oct 24, 2023
ijjk added a commit that referenced this pull request Oct 24, 2023
This seems to be causing our Windows x86_64 next-swc build to stall for
some reason so reverting so we can unblock canaries while we investigate
further

Reverts #57286

x-ref:
https://github.com/vercel/next.js/actions/runs/6620707993/job/17986458061
x-ref:
https://github.com/vercel/next.js/actions/runs/6620707993/job/17986458061
@github-actions github-actions bot added the locked label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants