Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor swc options #57369

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Refactor swc options #57369

merged 4 commits into from
Oct 25, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 24, 2023 •
edited
Loading

  • Rename swc option is_server to is_server_compiler
  • Rename swc plugin config.is_server to config.is_react_server_layer
  • Remove unused bundle_target, which could be covered by composing is_server_compiler and is_react_server_layer

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team. type: next labels Oct 24, 2023
@ijjk
Copy link
Member

ijjk commented Oct 25, 2023 •
edited
Loading

Tests Passed

@huozhi huozhi changed the title (wip) Refactor swc options Refactor swc options Oct 25, 2023
@huozhi huozhi marked this pull request as ready for review October 25, 2023 05:53
@kodiakhq kodiakhq bot merged commit 305bb01 into canary Oct 25, 2023
52 of 58 checks passed
@kodiakhq kodiakhq bot deleted the refactor/swc-options branch October 25, 2023 06:51
@github-actions github-actions bot added the locked label Nov 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@ztanner ztanner Awaiting requested review from ztanner

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @kdy1