Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: catch expected error in with-supabase example #57378

Conversation

dijonmusters
Copy link
Contributor

What?

[1] Use camelCase for SVG properties
[2] Catch expected error in cookie functions

Why?

[1] Prints error to the console
[2] If the cookies set or delete methods are called in a Server Component, an error is thrown

How?

[1] Change property names from kebab-case to camelCase
[2] Catch error

@dijonmusters dijonmusters requested review from a team as code owners October 25, 2023 01:05
@dijonmusters dijonmusters requested review from timeyoutakeit and lydiahallie and removed request for a team October 25, 2023 01:05
@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 25, 2023
@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Allow CI Workflow Run

  • approve CI run for commit: daad727

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@kodiakhq kodiakhq bot merged commit 4bc549b into vercel:canary Oct 26, 2023
52 checks passed
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants