Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: disable webpack specific test cases #57423

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 25, 2023

These tests test webpack specific behavior

Closes WEB-1857

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
buildDuration 10.1s 10s N/A
buildDurationCached 5.8s 5.9s N/A
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 417ms 420ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
index.html gzip 528 B 530 B N/A
link.html gzip 542 B 543 B N/A
withRouter.html gzip 524 B 524 B
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/disable-webpack-tests Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 28b6abb

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Failing test suites

Commit: 28b6abb

pnpm test test/integration/edge-runtime-configurable-guards/test/index.test.js

  • Edge runtime configurable guards > Multiple functions with different configurations > warns in dev for allowed code
Expand output

● Edge runtime configurable guards › Multiple functions with different configurations › warns in dev for allowed code

expect(received).toContain(expected) // indexOf

Expected substring: "Dynamic Code Evaluation (e. g. 'eval', 'new Function') not allowed in Edge Runtime"
Received string:    "   ▲ Next.js 13.5.7-canary.25
   - Local:        http://localhost:34147·
 ⨯ Middleware cannot be used with \"output: export\". See more info here: https://nextjs.org/docs/advanced-features/static-html-export
 ⨯ API Routes cannot be used with \"output: export\". See more info here: https://nextjs.org/docs/advanced-features/static-html-export
 ✓ Ready in 2.4s
 ○ Compiling / ...
 ✓ Compiled / in 868ms (191 modules)
"

  84 |       await waitFor(500)
  85 |       expect(res.status).toBe(200)
> 86 |       expect(context.logs.output).toContain(
     |                                   ^
  87 |         `Dynamic Code Evaluation (e. g. 'eval', 'new Function') not allowed in Edge Runtime`
  88 |       )
  89 |     })

  at Object.toContain (integration/edge-runtime-configurable-guards/test/index.test.js:86:35)

Read more about building and testing Next.js in contributing.md.

@sokra sokra merged commit d11156c into canary Oct 25, 2023
52 of 58 checks passed
@sokra sokra deleted the sokra/disable-webpack-tests branch October 25, 2023 18:35
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants