-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move serverActionsBodySizeLimit to serverActions.bodySizeLimit #57433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
Turbopack
Related to Turbopack with Next.js.
created-by: Next.js team
PRs by the Next.js team.
type: next
labels
Oct 25, 2023
huozhi
force-pushed
the
update-server-actions-exp-config
branch
from
October 26, 2023 05:23
00ba77c
to
5107aa7
Compare
huozhi
changed the title
(wip) Move serverActionsBodySizeLimit to serverActions.bodySizeLimit
Move serverActionsBodySizeLimit to serverActions.bodySizeLimit
Oct 26, 2023
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
buildDuration | 10.6s | 10.5s | N/A |
buildDurationCached | 6s | 6s | N/A |
nodeModulesSize | 175 MB | 175 MB | |
nextStartRea..uration (ms) | 424ms | 421ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
199-HASH.js gzip | 32.4 kB | 32.4 kB | N/A |
3f784ff6-HASH.js gzip | 53.2 kB | 53.2 kB | N/A |
99.HASH.js gzip | 182 B | 182 B | ✓ |
framework-HASH.js gzip | 45.5 kB | 45.5 kB | ✓ |
main-app-HASH.js gzip | 254 B | 252 B | N/A |
main-HASH.js gzip | 35.3 kB | 35.4 kB | N/A |
webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
Overall change | 45.7 kB | 45.7 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
_app-HASH.js gzip | 206 B | 205 B | N/A |
_error-HASH.js gzip | 182 B | 180 B | N/A |
amp-HASH.js gzip | 506 B | 505 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.59 kB | 2.59 kB | ✓ |
edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 369 B | 369 B | ✓ |
image-HASH.js gzip | 4.38 kB | 4.38 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 316 B | 318 B | N/A |
script-HASH.js gzip | 385 B | 384 B | N/A |
withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.99 kB | 3.99 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
_buildManifest.js gzip | 484 B | 482 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
index.html gzip | 528 B | 529 B | N/A |
link.html gzip | 540 B | 542 B | N/A |
withRouter.html gzip | 523 B | 525 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
edge-ssr.js gzip | 96 kB | 96 kB | N/A |
page.js gzip | 140 kB | 140 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js update-server-actions-exp-config | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 626 B | 619 B | N/A |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 25.6 kB | 25.6 kB | N/A |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 1.92 kB | 1.92 kB | ✓ |
Diff details
Diff for page.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
huozhi
requested review from
timneutkens,
ijjk,
shuding,
a team,
ztanner,
feedthejim and
wyattjoh
as code owners
October 26, 2023 05:39
huozhi
requested review from
ismaelrumzan and
delbaoliveira
and removed request for
a team
October 26, 2023 05:39
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @styfle:
|
shuding
approved these changes
Oct 26, 2023
Failing test suitesCommit: 2f198ff
Expand output● next.rs api › should have working HMR on client-side change on a app page 2
Read more about building and testing Next.js in contributing.md. |
ijjk
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Next.js team
PRs by the Next.js team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope all
serverActions
config in one group "serverActions" to make it more semantics