Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move serverActionsBodySizeLimit to serverActions.bodySizeLimit #57433

Merged
merged 11 commits into from
Oct 26, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 25, 2023

Scope all serverActions config in one group "serverActions" to make it more semantics

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team. type: next labels Oct 25, 2023
@huozhi huozhi force-pushed the update-server-actions-exp-config branch from 00ba77c to 5107aa7 Compare October 26, 2023 05:23
@huozhi huozhi changed the title (wip) Move serverActionsBodySizeLimit to serverActions.bodySizeLimit Move serverActionsBodySizeLimit to serverActions.bodySizeLimit Oct 26, 2023
@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
buildDuration 10.6s 10.5s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +4.31 kB
nextStartRea..uration (ms) 424ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
199-HASH.js gzip 32.4 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
index.html gzip 528 B 529 B N/A
link.html gzip 540 B 542 B N/A
withRouter.html gzip 523 B 525 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js update-server-actions-exp-config Change
middleware-b..fest.js gzip 626 B 619 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: 850a22b

@huozhi huozhi marked this pull request as ready for review October 26, 2023 05:39
@huozhi huozhi requested review from ismaelrumzan and delbaoliveira and removed request for a team October 26, 2023 05:39
@vercel-spaces
Copy link

vercel-spaces bot commented Oct 26, 2023

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @styfle:

packages/next/src/server/config.ts

@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Failing test suites

Commit: 2f198ff

pnpm test-dev test/development/basic/next-rs-api.test.ts

  • next.rs api > should have working HMR on client-side change on a app page 2
Expand output

● next.rs api › should have working HMR on client-side change on a app page 2

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  551 |             ).toEqual([expect.stringContaining(expectedUpdate)])
  552 |           }
> 553 |           expect(foundServerSideChange).toBe(expectedServerSideChange)
      |                                         ^
  554 |           ok = true
  555 |         } finally {
  556 |           try {

  at Object.toBe (development/basic/next-rs-api.test.ts:553:41)

Read more about building and testing Next.js in contributing.md.

@sokra sokra merged commit 07483d4 into canary Oct 26, 2023
49 of 55 checks passed
@sokra sokra deleted the update-server-actions-exp-config branch October 26, 2023 06:51
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants