Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add better messaging around wrapping postpone with try/catch #57446

Merged
merged 12 commits into from
Oct 26, 2023
Merged

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Oct 25, 2023

when calls to maybePostpone throw but there's no postpone state, we want to handle those errors differently so that we can provide clearer messaging around how to prevent them, while still retaining any errors that were re-thrown by the user.

ex:
CleanShot 2023-10-25 at 16 05 56@2x

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js ppr/logging Change
buildDuration 10.2s 10.3s ⚠️ +107ms
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +39.8 kB
nextStartRea..uration (ms) 411ms 427ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js ppr/logging Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ppr/logging Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js ppr/logging Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js ppr/logging Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js ppr/logging Change
index.html gzip 529 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary vercel/next.js ppr/logging Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB ⚠️ +290 B
Overall change 140 kB 140 kB ⚠️ +290 B
Middleware size
vercel/next.js canary vercel/next.js ppr/logging Change
middleware-b..fest.js gzip 626 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 199-HASH.js

Diff too large to display

Commit: 9d5d92d

@ztanner ztanner force-pushed the ppr/logging branch 3 times, most recently from f3ea82b to f992b5f Compare October 26, 2023 01:20
@ztanner ztanner marked this pull request as ready for review October 26, 2023 01:53
@ztanner ztanner requested review from jh3y and removed request for a team October 26, 2023 01:53
@ztanner ztanner requested a review from steven-tey October 26, 2023 01:53
huozhi
huozhi previously approved these changes Oct 26, 2023
@kodiakhq kodiakhq bot merged commit 0052c59 into canary Oct 26, 2023
98 of 103 checks passed
@kodiakhq kodiakhq bot deleted the ppr/logging branch October 26, 2023 02:51
ztanner added a commit that referenced this pull request Oct 26, 2023
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants