-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Node.js to fix repro templates (16 -> LTS) #57871
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should not be required, rather we should rely on the fact that CodeSandbox has this by default. (I pinged them about it).
Also, the reproduction template might not be used in CodeSandbox, so it doesn't feel correct to add this file.
Agree that this would be ideal! However, this could take months or years though, judging by how slowly Replit updated Node.js. It may be in a critical part of infrastructure that is not easy to change. In the meantime, the reproduction template is broken for users trying to report a bug, which is in my opinion very important to fix immediately. (it may also be broken for the App Router reproduction template, I didn't check it yet)
If it would be preferable to have it in |
@balazsorban44 I added reproduction steps and a screenshot to show the breakage, since that may have been unclear. |
@balazsorban44 I switched this PR to Dev Containers, which are not CodeSandbox-specific (and which already exist in various places in the Next.js repo). |
I chatted a bit with @CompuIves, and my current solution with Dev Containers would also be a preferable solution for CodeSandbox. @balazsorban44 the CodeSandbox reproductions are currently broken for users. How about going ahead with the Dev Containers version? (instead of waiting until some future point in time when CodeSandbox upgrades beyond v16) Another benefit with the Dev Containers version: it allows for the Next.js reproduction examples to specify the best specific Node.js version to run them on. |
Ideally, we should not need to add any additional files here. Awaiting response from our chat with the CodeSandbox team. |
CodeSandbox now defaults to Node.js 20 on new sandboxes, so this is not necessary anymore! |
Ok, thanks. In future this may come back again (eg. CodeSandbox is behind on Node.js versions and Next.js has already upgraded to a minimum beyond the CodeSandbox version), but I guess maintainers will revisit it then. |
What?
Upgrade Node.js version from 16 to LTS in CodeSandbox reproduction templates for both App Router and Pages Router
Why?
Currently the reproduction templates linked in the GitHub issues template is broken. This causes users reporting bugs to not be able to create reproductions.
(Next.js v14 has a minimum Node.js version of 18.17)
Reproduction steps:
yarn.lock
file to get the latest canary version (this I fixed separately in Remove outdated yarn.lock in CodeSandbox repros #57895 and Add empty yarn.lock to prevent caching #57896 )yarn
to install latest canary version16.17.0
How?
Change the base image to Node.js LTS bullseye image, using Dev Containers
CodeSandbox Demo of a fixed sandbox which applies this change: https://codesandbox.io/p/sandbox/zealous-ellis-t599tx?file=%2Fapp%2Fpage.tsx%3A4%2C2