Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enforce prop immutability in new next app #58845

Merged
merged 2 commits into from
Jan 5, 2024
Merged

style: enforce prop immutability in new next app #58845

merged 2 commits into from
Jan 5, 2024

Conversation

hamirmahal
Copy link
Contributor

@hamirmahal hamirmahal requested a review from a team as a code owner November 23, 2023 22:11
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Nov 23, 2023
@ijjk
Copy link
Member

ijjk commented Nov 23, 2023

Allow CI Workflow Run

  • approve CI run for commit: 072ae85

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 23, 2023

Allow CI Workflow Run

  • approve CI run for commit: 1358f6e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@styfle styfle added the CI approved Approve running CI for fork label Jan 5, 2024
@ijjk
Copy link
Member

ijjk commented Jan 5, 2024

Stats from current PR

Default Build
General
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
buildDuration 12.8s 12.8s N/A
buildDurationCached 7.1s 6s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 423ms 427ms N/A
Client Bundles (main, webpack)
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
433-HASH.js gzip 28.6 kB 28.6 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
index.html gzip 527 B 529 B N/A
link.html gzip 540 B 541 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 147 kB 147 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
middleware-b..fest.js gzip 626 B 622 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary hamirmahal/next.js style/enforce-prop-immutability-in-new-next-app Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 94.2 kB 94.2 kB
app-page-tur..prod.js gzip 94.9 kB 94.9 kB
app-page-tur..prod.js gzip 89.5 kB 89.5 kB
app-page.run...dev.js gzip 139 kB 139 kB
app-page.run..prod.js gzip 88.8 kB 88.8 kB
app-route-ex...dev.js gzip 24.1 kB 24.1 kB
app-route-ex..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.3 kB 16.3 kB
app-route.ru...dev.js gzip 23.5 kB 23.5 kB
app-route.ru..prod.js gzip 16.3 kB 16.3 kB
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.5 kB 49.5 kB
Overall change 932 kB 932 kB
Commit: a13135c

@styfle styfle merged commit f60c609 into vercel:canary Jan 5, 2024
63 of 68 checks passed
@hamirmahal hamirmahal deleted the style/enforce-prop-immutability-in-new-next-app branch January 5, 2024 23:51
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
- fixes vercel#58844

Co-authored-by: Steven <steven@ceriously.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript templates should have read-only props
3 participants