Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nextConfig headers not applying to static resources with i18n #59270

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Dec 4, 2023

Closed in favor of nextConfig.headers.locale being set to false. https://nextjs.org/docs/app/api-reference/next-config-js/headers#headers-with-i18n-support

@ztanner
Copy link
Member Author

ztanner commented Dec 4, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ijjk
Copy link
Member

ijjk commented Dec 4, 2023

Failing test suites

Commit: 850a552

pnpm test test/integration/custom-routes/test/index.test.js

  • Custom routes > production mode > should output routes-manifest successfully
Expand output

● Custom routes › production mode › should output routes-manifest successfully

expect(received).toEqual(expected) // deep equality

- Expected  -  0
+ Received  + 10

@@ -346,10 +346,20 @@
          },
        ],
        "regex": "^\\/has-header-4(?:\\/)?$",
        "source": "/has-header-4",
      },
+     Object {
+       "headers": Array [
+         Object {
+           "key": "X-Global-Custom-Header",
+           "value": "my custom header value",
+         },
+       ],
+       "regex": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))?(?:\\/)?$",
+       "source": "/:path*",
+     },
    ],
    "pages404": true,
    "redirects": Array [
      Object {
        "destination": "/:path+",

  1523 |       }
  1524 |
> 1525 |       expect(manifest).toEqual({
       |                        ^
  1526 |         version: 3,
  1527 |         pages404: true,
  1528 |         caseSensitive: true,

  at Object.toEqual (integration/custom-routes/test/index.test.js:1525:24)

Read more about building and testing Next.js in contributing.md.

@ztanner ztanner force-pushed the 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n branch from 3342c82 to 850a552 Compare December 4, 2023 22:47
@ijjk
Copy link
Member

ijjk commented Dec 4, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
buildDuration 10.4s 10.4s N/A
buildDurationCached 6s 6.6s ⚠️ +635ms
nodeModulesSize 199 MB 199 MB ⚠️ +842 B
nextStartRea..uration (ms) 424ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
199-HASH.js gzip 30.6 kB 30.6 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 240 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
index.html gzip 527 B 527 B
link.html gzip 537 B 541 B N/A
withRouter.html gzip 523 B 523 B
Overall change 1.05 kB 1.05 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
edge-ssr.js gzip 92.6 kB 92.7 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
middleware-b..fest.js gzip 624 B 624 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 35.7 kB 35.7 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 38.3 kB 38.3 kB
Next Runtimes
vercel/next.js canary vercel/next.js 12-04-fix_nextConfig_headers_not_applying_to_static_resources_with_i18n Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 93.8 kB 93.8 kB
app-page-tur..prod.js gzip 94.5 kB 94.5 kB
app-page-tur..prod.js gzip 89.1 kB 89.1 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.4 kB 88.4 kB
app-route-ex...dev.js gzip 24.2 kB 24.2 kB
app-route-ex..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route.ru...dev.js gzip 23.6 kB 23.6 kB
app-route.ru..prod.js gzip 16.4 kB 16.4 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.3 kB 49.3 kB
Overall change 930 kB 930 kB
Commit: 850a552

@ztanner ztanner closed this Dec 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants