Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app-router-migration.mdx to mention useRouter route not implemented in App Router #59342

Closed
wants to merge 1 commit into from

Conversation

giannif
Copy link

@giannif giannif commented Dec 6, 2023

route from next/router's useRouter is not mentioned in the migration guide. Other things are defined as missing such as asPath and basePath, but there is no mention of route.

This PR just mentions it's not implemented. I am not sure if there are plans to implement it.

The route property looks like so /product/[id], instead of /product/1234 which is available from usePathname

`route` from `next/router`'s `useRouter` is not mentioned in the migration guide. Other things are defined as missing such as `asPath` and `basePath` but there is no mention of `router`. Just mentioning it's not implemented yet
@giannif giannif requested review from a team as code owners December 6, 2023 18:53
@giannif giannif requested review from timeyoutakeit and delbaoliveira and removed request for a team December 6, 2023 18:53
@giannif giannif changed the title Update 02-app-router-migration.mdx Update app-router-migration.mdx to mention useRouter route not implemented in App Router Dec 6, 2023
@balazsorban44 balazsorban44 added Documentation Related to Next.js' official documentation. and removed area: documentation labels Apr 17, 2024
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked/landing in #70429

ijjk added a commit that referenced this pull request Sep 25, 2024
@ijjk ijjk closed this in #70429 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants