-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LayoutRouter: Support segment value of Promise<null> to asynchronously bail out and trigger a server patch #59724
Merged
acdlite
merged 1 commit into
vercel:canary
from
acdlite:async-trigger-lazy-server-patch
Dec 19, 2023
Merged
LayoutRouter: Support segment value of Promise<null> to asynchronously bail out and trigger a server patch #59724
acdlite
merged 1 commit into
vercel:canary
from
acdlite:async-trigger-lazy-server-patch
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the data for a segment is missing when LayoutRouter renders, it initiates a lazy fetch to patch the cache. This is how all dynamic data fetching works in the pre-PPR implementation. For PPR, we won't use this mechanism anymore for regular navigations, but (at least for now) we will still use it as a fallback behavior if the server response does not match what we expected to receive. This commit adds support for asynchronously triggering a lazy fetch, by unwrapping the segment data promise inside LayoutRouter to check if it's missing. If so, it will trigger the lazy fetch mechanism. When PPR is not enabled this should not observably impact behavior.
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for 170-HASH.jsDiff too large to display |
acdlite
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
December 18, 2023 03:45
2 tasks
ztanner
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the data for a segment is missing when LayoutRouter renders, it initiates a lazy fetch to patch the cache. This is how all dynamic data fetching works in the pre-PPR implementation.
For PPR, we won't use this mechanism anymore for regular navigations, but (at least for now) we will still use it as a fallback behavior if the server response does not match what we expected to receive.
This commit adds support for asynchronously triggering a lazy fetch, by unwrapping the segment data promise inside LayoutRouter to check if it's missing. If so, it will trigger the lazy fetch mechanism.
When PPR is not enabled this should not observably impact behavior.
Closes NEXT-1893