-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally bundle legacy react-dom/server APIs based on usage #59737
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
44a9442
Optionally bundle legacy react-dom/server APIs based on usage
huozhi 45f78df
fix browser alias
huozhi 5d44b0c
fix alias
huozhi d6f38d9
fix alias
huozhi a42b5a9
fix alias
huozhi dad3e04
rm
huozhi 27f0a85
update test
huozhi dbbf5dd
update test and alias
huozhi 861d069
change alias
huozhi 13931e1
fix lint
huozhi dea1f76
fix tests
huozhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
18 changes: 18 additions & 0 deletions
18
packages/next/src/build/webpack/alias/react-dom-server-browser-experimental.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
var l, s | ||
if (process.env.NODE_ENV === 'production') { | ||
l = require('next/dist/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.production.min.js') | ||
s = require('next/dist/compiled/react-dom-experimental/cjs/react-dom-server.browser.production.min.js') | ||
} else { | ||
l = require('next/dist/compiled/react-dom-experimental/cjs/react-dom-server-legacy.browser.development.js') | ||
s = require('next/dist/compiled/react-dom-experimental/cjs/react-dom-server.browser.development.js') | ||
} | ||
|
||
exports.version = l.version | ||
exports.renderToString = l.renderToString | ||
exports.renderToStaticMarkup = l.renderToStaticMarkup | ||
exports.renderToNodeStream = l.renderToNodeStream | ||
exports.renderToStaticNodeStream = l.renderToStaticNodeStream | ||
exports.renderToReadableStream = s.renderToReadableStream | ||
if (s.resume) { | ||
exports.resume = s.resume | ||
} |
18 changes: 18 additions & 0 deletions
18
packages/next/src/build/webpack/alias/react-dom-server-browser.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
var l, s | ||
if (process.env.NODE_ENV === 'production') { | ||
l = require('next/dist/compiled/react-dom/cjs/react-dom-server-legacy.browser.production.min.js') | ||
s = require('next/dist/compiled/react-dom/cjs/react-dom-server.browser.production.min.js') | ||
} else { | ||
l = require('next/dist/compiled/react-dom/cjs/react-dom-server-legacy.browser.development.js') | ||
s = require('next/dist/compiled/react-dom/cjs/react-dom-server.browser.development.js') | ||
} | ||
|
||
exports.version = l.version | ||
exports.renderToString = l.renderToString | ||
exports.renderToStaticMarkup = l.renderToStaticMarkup | ||
exports.renderToNodeStream = l.renderToNodeStream | ||
exports.renderToStaticNodeStream = l.renderToStaticNodeStream | ||
exports.renderToReadableStream = s.renderToReadableStream | ||
if (s.resume) { | ||
exports.resume = s.resume | ||
} |
23 changes: 23 additions & 0 deletions
23
packages/next/src/build/webpack/alias/react-dom-server-edge-experimental.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const ERROR_MESSAGE = | ||
'Internal Error: do not use legacy react-dom/server APIs. If you encountered this error, please open an issue on the Next.js repo.' | ||
|
||
function error() { | ||
throw new Error(ERROR_MESSAGE) | ||
} | ||
|
||
var b | ||
if (process.env.NODE_ENV === 'production') { | ||
b = require('next/dist/compiled/react-dom-experimental/cjs/react-dom-server.edge.production.min.js') | ||
} else { | ||
b = require('next/dist/compiled/react-dom-experimental/cjs/react-dom-server.edge.development.js') | ||
} | ||
|
||
exports.version = b.version | ||
exports.renderToReadableStream = b.renderToReadableStream | ||
exports.renderToNodeStream = b.renderToNodeStream | ||
exports.renderToStaticNodeStream = b.renderToStaticNodeStream | ||
exports.renderToString = error | ||
exports.renderToStaticMarkup = error | ||
if (b.resume) { | ||
exports.resume = b.resume | ||
} |
23 changes: 23 additions & 0 deletions
23
packages/next/src/build/webpack/alias/react-dom-server-edge.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const ERROR_MESSAGE = | ||
'Internal Error: do not use legacy react-dom/server APIs. If you encountered this error, please open an issue on the Next.js repo.' | ||
|
||
function error() { | ||
throw new Error(ERROR_MESSAGE) | ||
} | ||
|
||
var b | ||
if (process.env.NODE_ENV === 'production') { | ||
b = require('next/dist/compiled/react-dom/cjs/react-dom-server.edge.production.min.js') | ||
} else { | ||
b = require('next/dist/compiled/react-dom/cjs/react-dom-server.edge.development.js') | ||
} | ||
|
||
exports.version = b.version | ||
exports.renderToReadableStream = b.renderToReadableStream | ||
exports.renderToNodeStream = b.renderToNodeStream | ||
exports.renderToStaticNodeStream = b.renderToStaticNodeStream | ||
exports.renderToString = error | ||
exports.renderToStaticMarkup = error | ||
if (b.resume) { | ||
exports.resume = b.resume | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you copy this by hand? can't we automate something with taskr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file can be used in both dev and prod so this is expected?