Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation page on video optimization #60574

Merged
merged 62 commits into from
Jan 19, 2024
Merged

Add documentation page on video optimization #60574

merged 62 commits into from
Jan 19, 2024

Conversation

StephDietz
Copy link
Contributor

@StephDietz StephDietz commented Jan 12, 2024 •
edited
Loading

I've added a new page to the Next.js docs about optimizing videos. It covers:

  • the native video and iframe tag
  • displaying externally hosted videos (i.e. from youtube)
  • self hosting strategies and best practices
  • Video optimization techniques

@ijjk ijjk added area: documentation Font (next/font) Related to Next.js Font Optimization. created-by: Next.js Docs team PRs by the Docs team. labels Jan 12, 2024
@ijjk
Copy link
Member

ijjk commented Jan 12, 2024 •
edited by leerob
Loading

Allow CI Workflow Run

  • approve CI run for commit: 2217f88

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jan 12, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: 8653e0b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@StephDietz StephDietz marked this pull request as ready for review January 12, 2024 18:03
@StephDietz StephDietz requested review from ismaelrumzan and delbaoliveira and removed request for a team January 12, 2024 18:03
leerob
leerob reviewed Jan 12, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
leerob
leerob reviewed Jan 12, 2024
View reviewed changes
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/06-optimizing/02-videos.mdx Outdated Show resolved Hide resolved
StephDietz and others added 7 commits January 16, 2024 10:24
revert setting.json
12f5704
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
8cff0f2 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
5d58064 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
bfc73a3 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
bdd269c 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
391dbcf 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
6b6b007 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@balazsorban44 balazsorban44 mentioned this pull request Jan 19, 2024
Merged
StephDietz and others added 7 commits January 19, 2024 12:10
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
1d193a2 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
1046f6c 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
7657369 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
0600202 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
529e0ce 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz @leerob
Update docs/02-app/01-building-your-application/06-optimizing/02-vide…
c9431ea 
…os.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@StephDietz
Merge branch 'canary' into video-optimization-docs
8653e0b
samcx pushed a commit that referenced this pull request Jan 19, 2024
@balazsorban44
chore: fix core team members (#60900)
6217e3f 
### What?

Removing an outdated entry, and fixing the casing of another so Workflow
runs are auto-approved.

### Why?

#60574 fails the CI Workflow Run,
because of a mismatch in GitHub actor and the actual username set in
`labeler.json`


[Ref](https://github.com/vercel/nextjs-hive-docker/blob/c26bc3f26520b41986a0f9467fdc2529f705d81f/validate-job.js#L39-L42),
[Slack
thread](https://vercel.slack.com/archives/C03S9JCH2Q5/p1705684536884389?thread_ts=1705436555.494229&cid=C03S9JCH2Q5)

Closes NEXT-2172
@StephDietz StephDietz merged commit 4a74492 into canary Jan 19, 2024
34 checks passed
@StephDietz StephDietz deleted the video-optimization-docs branch January 19, 2024 19:09
@AhmedBaset
Copy link
Contributor

Since the next line starts with (spaces), the parser considers it as multi-line item and wrap the title in a new line

This code block has no left padding

@vordgi vordgi mentioned this pull request Jan 21, 2024
Open
@github-actions github-actions bot added the locked label Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delbaoliveira delbaoliveira delbaoliveira approved these changes

@cjpillsbury cjpillsbury cjpillsbury left review comments

@jlubawy jlubawy jlubawy left review comments

@manovotny manovotny manovotny left review comments

@heff heff heff left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan was automatically assigned from vercel/devex

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
created-by: Next.js Docs team PRs by the Docs team. Font (next/font) Related to Next.js Font Optimization. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@StephDietz @ijjk @AhmedBaset @heff @manovotny @jlubawy @cjpillsbury @leerob @delbaoliveira @balazsorban44