-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(turbopack): custom page extensions for _app
#60789
Merged
timneutkens
merged 2 commits into
canary
from
hrmny/pack-2085-pageextensions-for-custom-app
Jan 24, 2024
Merged
fix(turbopack): custom page extensions for _app
#60789
timneutkens
merged 2 commits into
canary
from
hrmny/pack-2085-pageextensions-for-custom-app
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForsakenHarmony
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
January 17, 2024 19:03
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the Turbopack team.
type: next
labels
Jan 17, 2024
Tests Passed |
ForsakenHarmony
force-pushed
the
hrmny/pack-2085-pageextensions-for-custom-app
branch
from
January 18, 2024 15:07
0f4d67f
to
ebb0d07
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ForsakenHarmony and the rest of your teammates on Graphite |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
ForsakenHarmony
force-pushed
the
hrmny/pack-2085-pageextensions-for-custom-app
branch
3 times, most recently
from
January 19, 2024 16:21
0f1a3ba
to
0d8d23c
Compare
ForsakenHarmony
requested review from
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
January 19, 2024 16:21
ForsakenHarmony
force-pushed
the
hrmny/pack-2085-pageextensions-for-custom-app
branch
2 times, most recently
from
January 22, 2024 13:36
6f3ca78
to
95d5253
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2085-pageextensions-for-custom-app
branch
from
January 22, 2024 16:16
95d5253
to
b927116
Compare
timneutkens
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The import alias had no way to resolve the page extensions and we already have them resolved in the
PagesStructure
, so with this PR we use the already resolved paths.Closes PACK-2085
Fixes #59264