Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turbopack): custom page extensions for _app #60789

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Jan 17, 2024

What?

The import alias had no way to resolve the page extensions and we already have them resolved in the PagesStructure, so with this PR we use the already resolved paths.

Closes PACK-2085
Fixes #59264

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Jan 17, 2024
@ijjk
Copy link
Member

ijjk commented Jan 17, 2024

Tests Passed

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2085-pageextensions-for-custom-app branch from 0f4d67f to ebb0d07 Compare January 18, 2024 15:07
@ForsakenHarmony
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ForsakenHarmony and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Jan 18, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
buildDuration 11.6s 11.7s N/A
buildDurationCached 6s 4.9s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 426ms 427ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
433-HASH.js gzip 29 kB 29 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
_buildManifest.js gzip 484 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
index.html gzip 528 B 525 B N/A
link.html gzip 540 B 538 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
middleware-b..fest.js gzip 625 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js hrmny/pack-2085-pageextensions-for-custom-app Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 96.3 kB 96.3 kB
app-page-tur..prod.js gzip 90.9 kB 90.9 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 24.2 kB 24.2 kB
app-route-ex..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route.ru...dev.js gzip 23.6 kB 23.6 kB
app-route.ru..prod.js gzip 16.4 kB 16.4 kB
pages-api-tu..prod.js gzip 9.41 kB 9.41 kB
pages-api.ru...dev.js gzip 9.68 kB 9.68 kB
pages-api.ru..prod.js gzip 9.4 kB 9.4 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 944 kB 944 kB
Commit: 61e6e43

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2085-pageextensions-for-custom-app branch 3 times, most recently from 0f1a3ba to 0d8d23c Compare January 19, 2024 16:21
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2085-pageextensions-for-custom-app branch 2 times, most recently from 6f3ca78 to 95d5253 Compare January 22, 2024 13:36
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2085-pageextensions-for-custom-app branch from 95d5253 to b927116 Compare January 22, 2024 16:16
@timneutkens timneutkens merged commit 21c2f85 into canary Jan 24, 2024
70 checks passed
@timneutkens timneutkens deleted the hrmny/pack-2085-pageextensions-for-custom-app branch January 24, 2024 21:15
@github-actions github-actions bot added the locked label Feb 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next dev --turbo does not respect pageExtensions for custom App/Document
3 participants