Report HMR latency as trace spans for Turbopack #60799

wbinnssmith · 2024-01-18T00:25:45Z

This:

Makes makes reporting hmr changes more accurate by emitting an explicit start event and lowering the aggregation period for reporting completed turbo tasks
Parameterizes the aggregation period, allowing JS subscribers to request different intervals, such as for the next-rs-api test
Aligns path pattern with webpack by normalizing its layer names
Fixes a bug in drainAndGetNext where the stream never could drain past the first item
Sends client-hmr-latency spans from Turbopack in both page and app router pages

This: - Makes makes reporting hmr changes more accurate by emitting an explicit start event and lowering the aggregation period for reporting completed turbo tasks - Parameterizes the aggregation period, allowing JS subscribers to request different intervals, such as for the next-rs-api test - Aligns path pattern with webpack by normalizing its layer names - Fixes a bug in `drainAndGetNext` where the stream never could drain past the first item - Sends `client-hmr-latency` spans from Turbopack in both page and app router pages

ijjk · 2024-01-18T00:49:31Z

Failing test suites

Commit: 7b526fb

pnpm test test/integration/auto-export-query-error/test/index.test.js

Auto Export > production mode > should show warning for query provided for auto exported page correctly

Expand output

● Auto Export › production mode › should show warning for query provided for auto exported page correctly

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  23 | describe('Auto Export', () => {
  24 |   ;(process.env.TURBOPACK ? describe.skip : describe)('production mode', () => {
> 25 |     beforeAll(async () => {
     |     ^
  26 |       const { stderr: curStderr, code: curCode } = await nextBuild(appDir, [], {
  27 |         stderr: true,
  28 |       })

  at beforeAll (integration/auto-export-query-error/test/index.test.js:25:5)
  at integration/auto-export-query-error/test/index.test.js:24:52
  at Object.describe (integration/auto-export-query-error/test/index.test.js:23:1)

Read more about building and testing Next.js in contributing.md.

ijjk · 2024-01-18T00:49:31Z

Tests Passed

packages/next/src/server/lib/router-utils/setup-dev-bundler.ts

sokra · 2024-01-18T07:26:52Z

packages/next/src/server/lib/router-utils/setup-dev-bundler.ts

      turbopackUpdates.push(payload)
-      hmrEventHappened = true
-      sendHmrDebounce()


Why no longer calling this? Shouldn't it send out the events immediately and don't wait for the end event?

What's the answer to this?

I reintroduced this call, so it's updating immediately again.

…60739)

ijjk · 2024-01-18T18:58:50Z

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
buildDuration	11.7s	11.6s	N/A
buildDurationCached	5.9s	5s	N/A
nodeModulesSize	200 MB	200 MB	⚠️ +15.4 kB
nextStartRea..uration (ms)	429ms	431ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
193.HASH.js gzip	181 B	182 B	N/A
3f784ff6-HASH.js gzip	53.4 kB	53.4 kB	✓
433-HASH.js gzip	29 kB	29 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	239 B	243 B	N/A
main-HASH.js gzip	31.8 kB	31.8 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	N/A
Overall change	98.6 kB	98.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	183 B	181 B	N/A
amp-HASH.js gzip	504 B	502 B	N/A
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	255 B	253 B	N/A
head-HASH.js gzip	350 B	349 B	N/A
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.18 kB	4.18 kB	N/A
index-HASH.js gzip	255 B	256 B	N/A
link-HASH.js gzip	2.61 kB	2.61 kB	✓
routerDirect..HASH.js gzip	312 B	311 B	N/A
script-HASH.js gzip	385 B	383 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.4 kB	3.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
_buildManifest.js gzip	484 B	485 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
index.html gzip	528 B	528 B	✓
link.html gzip	540 B	540 B	✓
withRouter.html gzip	523 B	523 B	✓
Overall change	1.59 kB	1.59 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
edge-ssr.js gzip	94 kB	94 kB	N/A
page.js gzip	149 kB	149 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
middleware-b..fest.js gzip	625 B	627 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	37.5 kB	37.5 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	2.07 kB	2.07 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js wbinnssmith/timing	Change
app-page-exp...dev.js gzip	169 kB	169 kB	✓
app-page-exp..prod.js gzip	95.6 kB	95.6 kB	✓
app-page-tur..prod.js gzip	96.3 kB	96.3 kB	✓
app-page-tur..prod.js gzip	90.9 kB	90.9 kB	✓
app-page.run...dev.js gzip	142 kB	142 kB	✓
app-page.run..prod.js gzip	90.2 kB	90.2 kB	✓
app-route-ex...dev.js gzip	24.2 kB	24.2 kB	✓
app-route-ex..prod.js gzip	16.9 kB	16.9 kB	✓
app-route-tu..prod.js gzip	16.9 kB	16.9 kB	✓
app-route-tu..prod.js gzip	16.4 kB	16.4 kB	✓
app-route.ru...dev.js gzip	23.6 kB	23.6 kB	✓
app-route.ru..prod.js gzip	16.4 kB	16.4 kB	✓
pages-api-tu..prod.js gzip	9.41 kB	9.41 kB	✓
pages-api.ru...dev.js gzip	9.68 kB	9.68 kB	✓
pages-api.ru..prod.js gzip	9.4 kB	9.4 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	22.6 kB	22.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	49.7 kB	49.7 kB	✓
Overall change	944 kB	944 kB	✓

Commit: d00df33

packages/next/src/client/dev/error-overlay/hot-dev-client.ts

packages/next/src/server/lib/router-utils/setup-dev-bundler.ts

…pack hmr updates

wbinnssmith requested review from timneutkens, ijjk, shuding, huozhi, a team, feedthejim, ztanner and wyattjoh as code owners January 18, 2024 00:25

ijjk added area: tests created-by: Turbopack team PRs by the Turbopack team. type: next labels Jan 18, 2024

wbinnssmith requested review from sokra, kwonoj and mknichel January 18, 2024 00:27

fixup! Report HMR latency as trace spans for Turbopack

7b526fb

sokra reviewed Jan 18, 2024

View reviewed changes

packages/next/src/server/lib/router-utils/setup-dev-bundler.ts Show resolved Hide resolved

sokra reviewed Jan 18, 2024

View reviewed changes

wbinnssmith added 2 commits January 18, 2024 10:48

fixup! Report HMR latency as trace spans for Turbopack

8b35844

fixup! feat: stabilize unstable_getImgProps() => getImageProps() (#…

c1b2214

…60739)

sokra reviewed Jan 18, 2024

View reviewed changes

packages/next/src/client/dev/error-overlay/hot-dev-client.ts Outdated Show resolved Hide resolved

sokra reviewed Jan 18, 2024

View reviewed changes

packages/next/src/server/lib/router-utils/setup-dev-bundler.ts Outdated Show resolved Hide resolved

wbinnssmith and others added 5 commits January 18, 2024 11:40

fixup! Report HMR latency as trace spans for Turbopack

914f6db

Merge remote-tracking branch 'origin/canary' into wbinnssmith/timing

8a54b19

add types to Sync/BuiltAction

b691c69

avoid sending built event on turbopack updates

8c53a29

aggregate end event a little bit

9ede6bc

sokra added 8 commits January 19, 2024 12:55

fix NEXT_HMR_TIMING for server side changes that require refetch

fda6cc4

proxy turbopack message through next client to wrap and measure turbo…

39201b9

…pack hmr updates

handle turbopack updates even if no updated modules can be extracted

c3555bf

send non turbopack hmr events immediately too

41fcfb3

remove finishBuilding event

166ef07

fix double encoding of message

64725a9

Merge branch 'canary' into wbinnssmith/timing

41551fa

Merge branch 'canary' into wbinnssmith/timing

53d6469

sokra approved these changes Jan 19, 2024

View reviewed changes

wbinnssmith added 2 commits January 19, 2024 14:50

fixup! Report HMR latency as trace spans for Turbopack

196829b

Merge remote-tracking branch 'origin/canary' into wbinnssmith/timing

d00df33

wbinnssmith merged commit 7b9e711 into canary Jan 19, 2024
67 checks passed

wbinnssmith deleted the wbinnssmith/timing branch January 19, 2024 23:34

vordgi mentioned this pull request Jan 21, 2024

Remove obsolete ("remove after next minor") #60930

Open

github-actions bot added the locked label Feb 5, 2024

github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report HMR latency as trace spans for Turbopack #60799

Report HMR latency as trace spans for Turbopack #60799

wbinnssmith commented Jan 18, 2024 •

edited by padmaia

Loading

ijjk commented Jan 18, 2024

ijjk commented Jan 18, 2024 •

edited

Loading

sokra Jan 18, 2024

sokra Jan 18, 2024

wbinnssmith Jan 18, 2024

ijjk commented Jan 18, 2024 •

edited

Loading

Report HMR latency as trace spans for Turbopack #60799

Report HMR latency as trace spans for Turbopack #60799

Conversation

wbinnssmith commented Jan 18, 2024 • edited by padmaia Loading

ijjk commented Jan 18, 2024

Failing test suites

ijjk commented Jan 18, 2024 • edited Loading

Tests Passed

sokra Jan 18, 2024

Choose a reason for hiding this comment

sokra Jan 18, 2024

Choose a reason for hiding this comment

wbinnssmith Jan 18, 2024

Choose a reason for hiding this comment

ijjk commented Jan 18, 2024 • edited Loading

Stats from current PR

wbinnssmith commented Jan 18, 2024 •

edited by padmaia

Loading

ijjk commented Jan 18, 2024 •

edited

Loading

ijjk commented Jan 18, 2024 •

edited

Loading