Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added @sentry/profiling-node to sep list to prevent build/bundle breakage #60855

Merged
merged 3 commits into from
Jan 19, 2024
Merged

fix: added @sentry/profiling-node to sep list to prevent build/bundle breakage #60855

merged 3 commits into from
Jan 19, 2024

Conversation

JesseKoldewijn
Copy link
Contributor

Issue: #60853

What?

Added @sentry/profiling-node to the server-external-package object so that sentry users who want to use this package don't have to manually add this package in the experimental nextjs config entry.

Why?

Package bundling will fail as shown in the following issue if not added to this exclude list.
getsentry/profiling-node#170


Fixes #60853

@JesseKoldewijn
Copy link
Contributor Author

Ps. also changed the location of @libsql/client in this list so this one adheres to the alphabetical order mentioned in one of my earlier PR's replies received from the core team.

@JesseKoldewijn
Copy link
Contributor Author

If any changes are required, please let me know! 😃

@styfle styfle added the CI approved Approve running CI for fork label Jan 19, 2024
@ijjk
Copy link
Member

ijjk commented Jan 19, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
buildDuration 12.9s 13s ⚠️ +132ms
buildDurationCached 7.1s 6.3s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +112 B
nextStartRea..uration (ms) 429ms 430ms N/A
Client Bundles (main, webpack)
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
433-HASH.js gzip 29 kB 29 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 239 B 243 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
_buildManifest.js gzip 484 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
index.html gzip 528 B 524 B N/A
link.html gzip 541 B 537 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary JesseKoldewijn/module-parse-fix-sentry-profiler-node canary Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 96.3 kB 96.3 kB
app-page-tur..prod.js gzip 90.8 kB 90.8 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 24.2 kB 24.2 kB
app-route-ex..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route.ru...dev.js gzip 23.6 kB 23.6 kB
app-route.ru..prod.js gzip 16.4 kB 16.4 kB
pages-api-tu..prod.js gzip 9.39 kB 9.39 kB
pages-api.ru...dev.js gzip 9.67 kB 9.67 kB
pages-api.ru..prod.js gzip 9.39 kB 9.39 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 943 kB 943 kB
Commit: b6eaa6a

@ijjk ijjk enabled auto-merge (squash) January 19, 2024 05:12
@ijjk ijjk merged commit 3734ae8 into vercel:canary Jan 19, 2024
80 checks passed
@github-actions github-actions bot added the locked label Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: @sentry/profiler-node
3 participants