Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(analysis): rust based page-static-info, deprecate js parse interface in next-swc" #61021

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 23, 2024

Reverts #59300

Breaks app/page.mdx files

Closes PACK-2279

Copy link

linear bot commented Jan 23, 2024

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Jan 23, 2024
@ijjk
Copy link
Member

ijjk commented Jan 23, 2024

Failing test suites

Commit: 4dc0198

pnpm test test/integration/next-image-legacy/image-from-node-modules/test/index.test.ts

  • Image Component Tests In Dev Mode > should apply image config for node_modules
Expand output

● Image Component Tests In Dev Mode › should apply image config for node_modules

expect(received).toMatch(expected)

Expected substring: "i.imgur.com"
Received string:    "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"

  21 |     expect(
  22 |       await browser.elementById('image-from-node-modules').getAttribute('src')
> 23 |     ).toMatch('i.imgur.com')
     |       ^
  24 |   })
  25 | }
  26 |

  at Object.toMatch (integration/next-image-legacy/image-from-node-modules/test/index.test.ts:23:7)

Read more about building and testing Next.js in contributing.md.

@sokra sokra merged commit 3a7fea4 into canary Jan 23, 2024
57 of 65 checks passed
@sokra sokra deleted the revert-59300-refactor-parse-module branch January 23, 2024 11:00
@github-actions github-actions bot added the locked label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants