Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-next-app: update tailwind packages and new classes in page.tsx #61065

Merged

Conversation

Dannymx
Copy link
Contributor

@Dannymx Dannymx commented Jan 24, 2024

  • Updates tailwindcss package
  • Fixes classes order based on eslint-plugin-tailwindcss
  • Remove/updates certain classes that now have shorthands, for example lg:h-auto lg:w-auto is now lg:size-auto
  • Removes unnecessary curly braces

@Dannymx Dannymx requested a review from a team as a code owner January 24, 2024 03:43
@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jan 24, 2024
@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: f0d000d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: f0d000d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2493bae

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) January 24, 2024 07:38
@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Stats from current PR

Default Build
General
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
buildDuration 11.9s 11.8s N/A
buildDurationCached 6.3s 5.4s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 408ms 406ms N/A
Client Bundles (main, webpack)
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
index.html gzip 527 B 527 B
link.html gzip 541 B 539 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 527 B 527 B
Edge SSR bundle Size
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary Dannymx/next.js chore/update-create-next-app-when-using-tailwind Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.7 kB 95.7 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.6 kB 21.6 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.42 kB 9.42 kB
pages-api.ru...dev.js gzip 9.69 kB 9.69 kB
pages-api.ru..prod.js gzip 9.42 kB 9.42 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Commit: e62cfba

@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Tests Passed

@Dannymx
Copy link
Contributor Author

Dannymx commented Jan 26, 2024

@samcx It seems like every time this branch gets updated a new test breaks, is there a way to get this merged?

@samcx
Copy link
Member

samcx commented Jan 26, 2024

@Dannymx Unfortunately due to flaky tests. Will take a look while we try to get this merged!

@samcx samcx merged commit c34b398 into vercel:canary Jan 29, 2024
61 of 66 checks passed
@Dannymx Dannymx deleted the chore/update-create-next-app-when-using-tailwind branch January 29, 2024 22:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants