Update blog-starter to App Router
#61170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeevo
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
ztanner and
a team
as code owners
zeevo
requested review from
timeyoutakeit and
delbaoliveira
and removed request for
a team
zeevo
force-pushed
the
update-blog-starter
branch
4 times, most recently
from
f2dc77e
to
19cec62
Compare
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
zeevo
commented
Jan 26, 2024
zeevo
force-pushed
the
update-blog-starter
branch
from
cfc8e6c
to
05c9389
Compare
auto-merge was automatically disabled
January 30, 2024 00:12
Head branch was pushed to by a user without write access
zeevo
force-pushed
the
update-blog-starter
branch
from
8ec9626
to
315dc9b
Compare
|
Can I have some guidance on how to get all of the Checks to pass? |
|
@zeevo Only maintainers are allowed to approve CI runs so I went ahead and approved your commit again. There was an issue with the |
|
@samcx Woot! Thank you for the merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates the
blog-starterexample to Next 14.1 App Router.Why?
I checked out a new
blog-starterproject on Vercel and was surprised it was using the Pages Router. I believe the App Router is a better choice.How?
I tried to keep the implementation logic as close to the original Pages
blog-starter.