-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert changes to process default routes at build #61241
Merged
ztanner
merged 1 commit into
canary
from
01-26-revert_changes_to_process_default_routes_at_build
Jan 27, 2024
Merged
revert changes to process default routes at build #61241
ztanner
merged 1 commit into
canary
from
01-26-revert_changes_to_process_default_routes_at_build
Jan 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
ztanner
force-pushed
the
01-26-revert_changes_to_process_default_routes_at_build
branch
from
January 27, 2024 00:51
6414e22
to
64749aa
Compare
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
ztanner
force-pushed
the
01-26-revert_changes_to_process_default_routes_at_build
branch
from
January 27, 2024 00:52
64749aa
to
3bd396f
Compare
ztanner
force-pushed
the
01-26-revert_changes_to_process_default_routes_at_build
branch
from
January 27, 2024 00:53
3bd396f
to
01659a5
Compare
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
a team and
wyattjoh
as code owners
January 27, 2024 01:02
samcx
approved these changes
Jan 27, 2024
ijjk
approved these changes
Jan 27, 2024
ztanner
deleted the
01-26-revert_changes_to_process_default_routes_at_build
branch
January 27, 2024 02:10
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts changes from #61173 & #60240 (while leaving the tests that were added).
There are too many spots where considering
/default
routes as pages needs to be carefully considered in different runtimes, and it turns out that it's not actually needed to handle the case that it was originally added for. I confirmed that the test that added the case it was intended to fix (parallel-routes-catchall-default
, along with the unit tests innormalize-catchall-routes
) are still passing as expected.