Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next-image-new/app-dir for Turbopack #61282

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jan 28, 2024

What?

Fixes this test for Turbopack.

Closes NEXT-2275

@timneutkens timneutkens requested review from jh3y and molebox and removed request for a team January 28, 2024 12:30
@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Jan 28, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Jan 28, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
buildDuration 11.6s 11.6s N/A
buildDurationCached 6.3s 5.3s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 426ms 425ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js 01-28-Fix_next-image-new/app-dir_for_Turbopack Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.7 kB 95.7 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.6 kB 21.6 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.42 kB 9.42 kB
pages-api.ru...dev.js gzip 9.69 kB 9.69 kB
pages-api.ru..prod.js gzip 9.42 kB 9.42 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Commit: 68afa61

@ijjk
Copy link
Member

ijjk commented Jan 28, 2024

Failing test suites

Commit: ca17470

pnpm test test/integration/next-image-new/app-dir/test/index.test.ts

  • Image Component Default Tests > dev mode > should lazy load with placeholder=blur
  • Image Component Default Tests > production mode > should lazy load with placeholder=blur
Expand output

● Image Component Default Tests › dev mode › should lazy load with placeholder=blur

expect(received).toBe(expected) // Object.is equality

Expected: /\/_next\/image\?url=%2F_next%2Fstatic%2Fmedia%2Ftest\.(.*)\.jpg&w=828&q=75/
Received: "/_next/image?url=%2F_next%2Fstatic%2Fmedia%2Ftest.fab2915d.jpg&w=828&q=75"

  634 |
  635 |     // blur1
> 636 |     expect(await browser.elementById('blur1').getAttribute('src')).toBe(
      |                                                                    ^
  637 |       /\/_next\/image\?url=%2F_next%2Fstatic%2Fmedia%2Ftest\.(.*)\.jpg&w=828&q=75/
  638 |     )
  639 |     expect(await browser.elementById('blur1').getAttribute('srcset')).toBe(

  at Object.toBe (integration/next-image-new/app-dir/test/index.test.ts:636:68)

● Image Component Default Tests › production mode › should lazy load with placeholder=blur

expect(received).toBe(expected) // Object.is equality

Expected: /\/_next\/image\?url=%2F_next%2Fstatic%2Fmedia%2Ftest\.(.*)\.jpg&w=828&q=75/
Received: "/_next/image?url=%2F_next%2Fstatic%2Fmedia%2Ftest.fab2915d.jpg&w=828&q=75"

  634 |
  635 |     // blur1
> 636 |     expect(await browser.elementById('blur1').getAttribute('src')).toBe(
      |                                                                    ^
  637 |       /\/_next\/image\?url=%2F_next%2Fstatic%2Fmedia%2Ftest\.(.*)\.jpg&w=828&q=75/
  638 |     )
  639 |     expect(await browser.elementById('blur1').getAttribute('srcset')).toBe(

  at Object.toBe (integration/next-image-new/app-dir/test/index.test.ts:636:68)

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens merged commit c4e6f78 into canary Jan 29, 2024
60 of 66 checks passed
@timneutkens timneutkens deleted the 01-28-Fix_next-image-new/app-dir_for_Turbopack branch January 29, 2024 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants