Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update link.mdx #61508

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Docs: update link.mdx #61508

merged 3 commits into from
Feb 16, 2024

Conversation

kevinmitch14
Copy link
Contributor

@kevinmitch14 kevinmitch14 commented Feb 1, 2024

Updated paths in relation to <Link /> and middleware rewrites. Feel free to leave suggestions if needed, this has always confused me a little bit.

Old Version:
For example, if you have a Dynamic Route like /dashboard/[user] that you want to present differently via middleware, you would write: <Link href={{ pathname: '/dashboard/authed/[user]', query: { user: username } }} as="/dashboard/[user]">Profile</Link>.

The as prop should be the URL we want to display while href/pathname is the actual path. So if we want to present something differently via middleware, we would do so via as. In the example above we want to display /dashboard/[user] differently but we use as='/dashboard/[user]'.

@kevinmitch14 kevinmitch14 requested review from a team as code owners February 1, 2024 14:54
@kevinmitch14 kevinmitch14 requested review from jh3y and StephDietz and removed request for a team February 1, 2024 14:54
@ijjk
Copy link
Member

ijjk commented Feb 1, 2024

Allow CI Workflow Run

  • approve CI run for commit: 7beb70a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Feb 4, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary erfanium/next.js patch-2 Change
buildDuration 20.8s 20.7s N/A
buildDurationCached 8.9s 7.6s N/A
nodeModulesSize 196 MB 196 MB ⚠️ +360 B
nextStartRea..uration (ms) 412ms 413ms N/A
Client Bundles (main, webpack)
vercel/next.js canary erfanium/next.js patch-2 Change
1068-HASH.js gzip 30.2 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.1 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary erfanium/next.js patch-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary erfanium/next.js patch-2 Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary erfanium/next.js patch-2 Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary erfanium/next.js patch-2 Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary erfanium/next.js patch-2 Change
edge-ssr.js gzip 94.4 kB 94.5 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary erfanium/next.js patch-2 Change
middleware-b..fest.js gzip 625 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 44.4 kB 44.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.1 kB 2.1 kB
Next Runtimes
vercel/next.js canary erfanium/next.js patch-2 Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 97.3 kB 97.3 kB
app-page-tur..prod.js gzip 91.8 kB 91.8 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 50 kB 50 kB
Overall change 925 kB 925 kB
build cache Overall increase ⚠️
vercel/next.js canary erfanium/next.js patch-2 Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 103 kB 103 kB ⚠️ +229 B
Overall change 103 kB 103 kB ⚠️ +229 B
Diff details
Diff for 1068-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 6d4ccf6

@ijjk
Copy link
Member

ijjk commented Feb 15, 2024

Tests Passed

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) February 16, 2024 19:40
@samcx samcx merged commit d397832 into vercel:canary Feb 16, 2024
31 checks passed
@github-actions github-actions bot added the locked label Mar 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants