Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Friendly Test was retired #61647

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari requested review from a team as code owners February 5, 2024 01:03
@oliviertassinari oliviertassinari requested review from manovotny and molebox and removed request for a team February 5, 2024 01:03
@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Allow CI Workflow Run

  • approve CI run for commit: c07b54f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Allow CI Workflow Run

  • approve CI run for commit: c07b54f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) February 5, 2024 01:06
@samcx samcx merged commit 6587a37 into vercel:canary Feb 5, 2024
29 checks passed
@oliviertassinari oliviertassinari deleted the patch-1 branch February 5, 2024 01:28
@@ -171,7 +171,7 @@ For more Suspense examples and use cases, please see the [React Documentation](h
### SEO

- Next.js will wait for data fetching inside [`generateMetadata`](/docs/app/api-reference/functions/generate-metadata) to complete before streaming UI to the client. This guarantees the first part of a streamed response includes `<head>` tags.
- Since streaming is server-rendered, it does not impact SEO. You can use the [Mobile Friendly Test](https://search.google.com/test/mobile-friendly) tool from Google to see how your page appears to Google's web crawlers and view the serialized HTML ([source](https://web.dev/rendering-on-the-web/#seo-considerations)).
- Since streaming is server-rendered, it does not impact SEO. You can use the [Rich Results Test](https://search.google.com/test/rich-results) tool from Google to see how your page appears to Google's web crawlers and view the serialized HTML ([source](https://web.dev/rendering-on-the-web/#seo-considerations)).
Copy link
Contributor Author

@oliviertassinari oliviertassinari Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the sentence as well, to be honest, "it does not impact SEO" looks like a false statement, there s an impact: #50829 (comment).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants