-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app-dir/next-font for Turbopack #61678
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on Graphite |
@@ -52,8 +45,12 @@ describe('app dir - next/font', () => { | |||
|
|||
// layout | |||
expect(JSON.parse($('#root-layout').text())).toEqual({ | |||
className: expect.stringMatching(/^__className_.{6}$/), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not want to keep the more specific regex for webpack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to match them a bit more, overall the format really doesn't matter as long as the class is there
Failing test suitesCommit: dcbd7a9
Expand output● app dir - basic › known bugs › should support React cache › server component client-navigation
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually it would be ideal to update the test manifest with this PR so the changes are tested before merging
What?
Updates the test checks for Turbopack.
Closes NEXT-2364