Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app-dir/next-font for Turbopack #61678

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 5, 2024

What?

Updates the test checks for Turbopack.

Closes NEXT-2364

@ijjk ijjk added Font (next/font) Related to Next.js Font Optimization. area: tests created-by: Next.js team PRs by the Next.js team. labels Feb 5, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@@ -52,8 +45,12 @@ describe('app dir - next/font', () => {

// layout
expect(JSON.parse($('#root-layout').text())).toEqual({
className: expect.stringMatching(/^__className_.{6}$/),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not want to keep the more specific regex for webpack?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to match them a bit more, overall the format really doesn't matter as long as the class is there

@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Failing test suites

Commit: dcbd7a9

pnpm test-dev test/e2e/app-dir/app/index.test.ts (PPR)

  • app dir - basic > known bugs > should support React cache > server component client-navigation
Expand output

● app dir - basic › known bugs › should support React cache › server component client-navigation

expect(received).toBe(expected) // Object.is equality

Expected: "0.27388344623421057"
Received: "0.38110681018068293"

  1543 |           const val1 = await browser.elementByCss('#value-1').text()
  1544 |           const val2 = await browser.elementByCss('#value-2').text()
> 1545 |           expect(val1).toBe(val2)
       |                        ^
  1546 |         })
  1547 |
  1548 |         it('client component', async () => {

  at Object.toBe (e2e/app-dir/app/index.test.ts:1545:24)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
buildDuration 11.6s 11.7s ⚠️ +136ms
buildDurationCached 5.9s 5.3s N/A
nodeModulesSize 196 MB 196 MB
nextStartRea..uration (ms) 427ms 435ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 501 B N/A
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.19 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 106 B 106 B
Client Build Manifests
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 538 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
edge-ssr.js gzip 94 kB 94.1 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
middleware-b..fest.js gzip 621 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.7 kB 37.7 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js 02-05-Fix_app-dir/next-font_for_Turbopack Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95 kB 95 kB
app-page-tur..prod.js gzip 96.8 kB 96.8 kB
app-page-tur..prod.js gzip 91.3 kB 91.3 kB
app-page.run...dev.js gzip 135 kB 135 kB
app-page.run..prod.js gzip 89.9 kB 89.9 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 921 kB 921 kB
Commit: dcbd7a9

Copy link
Contributor

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it would be ideal to update the test manifest with this PR so the changes are tested before merging

@timneutkens timneutkens requested a review from a team as a code owner February 5, 2024 16:28
@timneutkens timneutkens merged commit 55b472b into canary Feb 6, 2024
61 of 68 checks passed
@timneutkens timneutkens deleted the 02-05-Fix_app-dir/next-font_for_Turbopack branch February 6, 2024 07:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. Font (next/font) Related to Next.js Font Optimization. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants