-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add turbo.resolveExtensions to allow to customize extensions #62004
Conversation
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
buildDuration | 19.9s | 19.8s | N/A |
buildDurationCached | 8.5s | 6.9s | N/A |
nodeModulesSize | 196 MB | 196 MB | |
nextStartRea..uration (ms) | 428ms | 438ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
1068-HASH.js gzip | 30.3 kB | 30.3 kB | N/A |
3f784ff6-HASH.js gzip | 53.5 kB | 53.5 kB | N/A |
4944-HASH.js gzip | 5.04 kB | 5.03 kB | N/A |
8423.HASH.js gzip | 181 B | 181 B | ✓ |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 241 B | 241 B | ✓ |
main-HASH.js gzip | 32.1 kB | 32.1 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 47.3 kB | 47.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
_app-HASH.js gzip | 196 B | 196 B | ✓ |
_error-HASH.js gzip | 184 B | 183 B | N/A |
amp-HASH.js gzip | 503 B | 504 B | N/A |
css-HASH.js gzip | 323 B | 324 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.51 kB | N/A |
edge-ssr-HASH.js gzip | 258 B | 259 B | N/A |
head-HASH.js gzip | 353 B | 351 B | N/A |
hooks-HASH.js gzip | 370 B | 370 B | ✓ |
image-HASH.js gzip | 4.21 kB | 4.2 kB | N/A |
index-HASH.js gzip | 259 B | 259 B | ✓ |
link-HASH.js gzip | 2.68 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 313 B | 314 B | N/A |
script-HASH.js gzip | 386 B | 385 B | N/A |
withRouter-HASH.js gzip | 309 B | 311 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 931 B | 931 B | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
_buildManifest.js gzip | 485 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
index.html gzip | 528 B | 528 B | ✓ |
link.html gzip | 540 B | 541 B | N/A |
withRouter.html gzip | 524 B | 523 B | N/A |
Overall change | 528 B | 528 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
edge-ssr.js gzip | 94.5 kB | 94.5 kB | N/A |
page.js gzip | 151 kB | 151 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 627 B | 627 B | ✓ |
middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
middleware.js gzip | 44.6 kB | 44.6 kB | N/A |
edge-runtime..pack.js gzip | 1.94 kB | 1.94 kB | ✓ |
Overall change | 2.72 kB | 2.72 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 166 kB | 166 kB | ✓ |
app-page-exp..prod.js gzip | 95.9 kB | 95.9 kB | ✓ |
app-page-tur..prod.js gzip | 97.6 kB | 97.6 kB | ✓ |
app-page-tur..prod.js gzip | 92 kB | 92 kB | ✓ |
app-page.run...dev.js gzip | 136 kB | 136 kB | ✓ |
app-page.run..prod.js gzip | 90.6 kB | 90.6 kB | ✓ |
app-route-ex...dev.js gzip | 22 kB | 22 kB | ✓ |
app-route-ex..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.6 kB | 14.6 kB | ✓ |
app-route.ru...dev.js gzip | 21.7 kB | 21.7 kB | ✓ |
app-route.ru..prod.js gzip | 14.6 kB | 14.6 kB | ✓ |
pages-api-tu..prod.js gzip | 9.47 kB | 9.47 kB | ✓ |
pages-api.ru...dev.js gzip | 9.74 kB | 9.74 kB | ✓ |
pages-api.ru..prod.js gzip | 9.47 kB | 9.47 kB | ✓ |
pages-turbo...prod.js gzip | 22.1 kB | 22.1 kB | ✓ |
pages.runtim...dev.js gzip | 22.7 kB | 22.7 kB | ✓ |
pages.runtim..prod.js gzip | 22.1 kB | 22.1 kB | ✓ |
server.runti..prod.js gzip | 50.1 kB | 50.1 kB | ✓ |
Overall change | 927 kB | 927 kB | ✓ |
build cache
vercel/next.js canary | vercel/next.js sokra/resolve-extensions | Change | |
---|---|---|---|
0.pack gzip | 1.55 MB | 1.55 MB | N/A |
index.pack gzip | 104 kB | 103 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Failing test suitesCommit: 88768e7
Expand output● Prefetching Links in viewport › production mode › should prefetch with non-bot UA
Read more about building and testing Next.js in contributing.md. |
turbo: { | ||
resolveExtensions: ['png', 'tsx', 'ts', 'jsx', 'js', 'json'], | ||
}, | ||
webpack(config) { | ||
config.resolve.extensions = ['.png', '.tsx', '.ts', '.jsx', '.js', '.json'] | ||
return config | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just have a shared field both can read from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. It's only a test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I meant have a field in next.config.js which both turbopack and webpack read from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in this test, but in general
e.g. experimental.resolveExtensions
for now and read that in build/webpack-config.ts
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to introduce an option that you don't need to add twice
1b49110
to
2407c7b
Compare
What?
turbo.resolveExtensions
to allow to customize extensions in Turbopackfixes PACK-2335
Fixes vercel/turborepo#4934