Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sendGAEvent function #62065

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Fix sendGAEvent function #62065

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e15a68
refactor sendGAEvent to pass arguments object directly to dataLayer i…
Feb 14, 2024
520b697
Merge branch 'canary' into send-ga-event-fix
willashe Feb 14, 2024
c0724b8
Merge branch 'canary' into send-ga-event-fix
ijjk Feb 14, 2024
23be76f
Merge branch 'canary' into send-ga-event-fix
ijjk Feb 14, 2024
4572a3b
revert extra changes
ijjk Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/third-parties/src/google/ga.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ export function GoogleAnalytics(props: GAParams) {
)
}

export function sendGAEvent() {
export const sendGAEvent = (...args: Object[]) => {
if (currDataLayerName === undefined) {
console.warn(`@next/third-parties: GA has not been initialized`)
return
}

if (window[currDataLayerName]) {
window[currDataLayerName].push(arguments)
window[currDataLayerName].push(args)
Copy link
Contributor

@asobirov asobirov Feb 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to leave this one as arguments. It seems like this does not work with Arrays, but works with arguments object. Additionally, when using window.gtag(...) an Arguments() is pushed instead of Array().

Might be related, see: https://stackoverflow.com/questions/60400130/google-analytics-datalayer-push-not-working-with-array-of-variables#60410151

} else {
console.warn(
`@next/third-parties: GA dataLayer ${currDataLayerName} does not exist`
Expand Down