-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(turbopack): wrap manifest loading in helper class #62118
Conversation
6b84849
to
450cfde
Compare
Failing test suitesCommit: bf7110a
Expand output● Test suite failed to run
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - metadata › react cache › should have same title and page value when navigating
Read more about building and testing Next.js in contributing.md.
Expand output● interception-route-prefetch-cache › runtime = edge › should render the correct interception when two distinct layouts share the same path structure
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
|
450cfde
to
8ec86a3
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ForsakenHarmony and the rest of your teammates on Graphite |
8ec86a3
to
7ab1ee1
Compare
|
||
export type HandleRequireCacheClearing = ( | ||
export type HandleWrittenEndpoint = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this more generic is for a PR further down the stack
7ab1ee1
to
2b2e163
Compare
2b2e163
to
38c08fc
Compare
ef3960e
to
464032f
Compare
464032f
to
bf7110a
Compare
What?
All the manifest loading logic now lives in the
TurbopackManifestLoader
class.We have to pass way fewer arguments around to the functions now.
I've also cleaned up / restructured the arguments of the bigger functions in
turbopack-utils.ts
and gave some functions better names.Best reviewed with hidden whitespace
Closes PACK-2520