-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route/middleware/instrumentation use server assets instead of client assets #62134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the Turbopack team.
type: next
labels
Feb 16, 2024
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display |
sokra
force-pushed
the
sokra/route-chunking-and-url
branch
from
March 12, 2024 21:37
206a357
to
e7aa2c7
Compare
sokra
force-pushed
the
sokra/route-chunking-and-url
branch
from
March 12, 2024 21:38
e7aa2c7
to
1a37316
Compare
sokra
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
March 18, 2024 14:53
sokra
added a commit
to vercel/turborepo
that referenced
this pull request
Mar 19, 2024
### Description The default for asset prefix is `"/"` and not `""` ### Testing Instructions vercel/next.js#62134
server assets use full url rewrite
sokra
force-pushed
the
sokra/route-chunking-and-url
branch
from
March 20, 2024 10:12
4e4e639
to
d9ebb61
Compare
timneutkens
approved these changes
Mar 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
route/middleware/instrumentation use server assets
server assets use full url rewrite
Why?
How?
vercel/turborepo#7750
Fixes PACK-2522
fixes PACK-2645