Fix sendGAEvent function (for real?) #62192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asobirov
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
asobirov
changed the title
asobirov
commented
Feb 17, 2024
| @@ -54,14 +54,14 @@ export function GoogleAnalytics(props: GAParams) { | |||
| ) | |||
| } | |||
|
|
|||
| export const sendGAEvent = (...args: Object[]) => { | |||
| export function sendGAEvent(..._args: Object[]) { | |||
There was a problem hiding this comment.
Converted to a function so that arguments would be available.
Wasn't entirely sure of any other way to turn the args into Arguments() instead of Array(), so I just prefixed it with _ to have the types at least. Not sure though.
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ijjk
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Looking at the gtag docs it does seem to not handle Array values specifically so using arguments seems good to me
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently merged PR - #62065, doesn't seem to fix the issue. As per the comment this seems to be related to
dataLayerthat does not like working with Arrays, but works with arguments object. Also, when using window.gtag(...) an Arguments() is pushed instead of Array().Fixes #61703