-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scss tests into individual directories #62277
Merged
timneutkens
merged 1 commit into
canary
from
02-20-Move_scss_tests_into_individual_directories
Feb 21, 2024
Merged
Move scss tests into individual directories #62277
timneutkens
merged 1 commit into
canary
from
02-20-Move_scss_tests_into_individual_directories
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
February 20, 2024 12:56
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on Graphite |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
|
Base automatically changed from
02-20-Move_scss_tests_into_test/integration/scss_directory
to
canary
February 20, 2024 19:30
timneutkens
force-pushed
the
02-20-Move_scss_tests_into_individual_directories
branch
from
February 20, 2024 19:44
83a4e2c
to
0050a02
Compare
kwonoj
approved these changes
Feb 20, 2024
timneutkens
deleted the
02-20-Move_scss_tests_into_individual_directories
branch
February 21, 2024 08:49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Further simplifying the way the tests are created for Sass so that they can be moved into
test/e2e
in a follow-up PR.Closes NEXT-2537