-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update split chunk handling for edge/node" #62313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b5f7d9.
ijjk
requested review from
timneutkens,
shuding,
huozhi,
ztanner,
feedthejim,
a team and
wyattjoh
as code owners
February 21, 2024 08:17
Issue reopened: NEXT-2521 Update split chunk handling for edge/node |
ijjk
added
area: tests
created-by: Next.js team
PRs by the Next.js team.
type: next
labels
Feb 21, 2024
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
buildDuration | 14.4s | 20.3s | |
buildDurationCached | 8s | 7.9s | N/A |
nodeModulesSize | 196 MB | 196 MB | N/A |
nextStartRea..uration (ms) | 406ms | 408ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
1068-HASH.js gzip | 30.3 kB | 30.3 kB | N/A |
3f784ff6-HASH.js gzip | 53.5 kB | 53.5 kB | N/A |
4944-HASH.js gzip | 5.04 kB | 5.03 kB | N/A |
8423.HASH.js gzip | 181 B | 181 B | ✓ |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 241 B | 244 B | N/A |
main-HASH.js gzip | 32.2 kB | 32.1 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 47.1 kB | 47.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
_app-HASH.js gzip | 196 B | 196 B | ✓ |
_error-HASH.js gzip | 184 B | 183 B | N/A |
amp-HASH.js gzip | 503 B | 504 B | N/A |
css-HASH.js gzip | 323 B | 324 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.51 kB | N/A |
edge-ssr-HASH.js gzip | 258 B | 259 B | N/A |
head-HASH.js gzip | 353 B | 351 B | N/A |
hooks-HASH.js gzip | 370 B | 370 B | ✓ |
image-HASH.js gzip | 4.21 kB | 4.2 kB | N/A |
index-HASH.js gzip | 259 B | 259 B | ✓ |
link-HASH.js gzip | 2.68 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 313 B | 314 B | N/A |
script-HASH.js gzip | 386 B | 385 B | N/A |
withRouter-HASH.js gzip | 309 B | 311 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 931 B | 931 B | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
_buildManifest.js gzip | 485 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
index.html gzip | 529 B | 528 B | N/A |
link.html gzip | 541 B | 541 B | ✓ |
withRouter.html gzip | 525 B | 523 B | N/A |
Overall change | 541 B | 541 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
edge-ssr.js gzip | 2.29 kB | 94.8 kB | |
page.js gzip | 2.98 kB | 152 kB | |
Overall change | 5.26 kB | 247 kB |
Middleware size Overall increase ⚠️
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 627 B | 625 B | N/A |
middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
middleware.js gzip | 466 B | 44.9 kB | |
edge-runtime..pack.js gzip | 839 B | 1.94 kB | |
Overall change | 1.46 kB | 47 kB |
Next Runtimes
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 167 kB | 167 kB | ✓ |
app-page-exp..prod.js gzip | 96.2 kB | 96.2 kB | ✓ |
app-page-tur..prod.js gzip | 97.9 kB | 97.9 kB | ✓ |
app-page-tur..prod.js gzip | 92.4 kB | 92.4 kB | ✓ |
app-page.run...dev.js gzip | 136 kB | 136 kB | ✓ |
app-page.run..prod.js gzip | 90.9 kB | 90.9 kB | ✓ |
app-route-ex...dev.js gzip | 22.1 kB | 22.1 kB | ✓ |
app-route-ex..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.7 kB | 14.7 kB | ✓ |
app-route.ru...dev.js gzip | 21.8 kB | 21.8 kB | ✓ |
app-route.ru..prod.js gzip | 14.7 kB | 14.7 kB | ✓ |
pages-api-tu..prod.js gzip | 9.49 kB | 9.49 kB | ✓ |
pages-api.ru...dev.js gzip | 9.76 kB | 9.76 kB | ✓ |
pages-api.ru..prod.js gzip | 9.48 kB | 9.48 kB | ✓ |
pages-turbo...prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
pages.runtim...dev.js gzip | 23 kB | 23 kB | ✓ |
pages.runtim..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
server.runti..prod.js gzip | 50.3 kB | 50.3 kB | ✓ |
Overall change | 930 kB | 930 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js revert-62205-fix/chunk-groups | Change | |
---|---|---|---|
0.pack gzip | 1.49 MB | 1.55 MB | |
index.pack gzip | 104 kB | 104 kB | N/A |
Overall change | 1.49 MB | 1.55 MB |
Diff details
Diff for page.js
failed to diff
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
huozhi
approved these changes
Feb 21, 2024
ijjk
added a commit
to ijjk/next.js
that referenced
this pull request
Feb 21, 2024
)" This reverts commit fc0f94f.
ijjk
added a commit
that referenced
this pull request
Feb 21, 2024
…62336) This re-lands the chunking optimization with fix for the split chunks config to ensure we aren't generating duplicate chunks from not chunking `all` together. Tested various configs against our repro case here: https://vercel.com/vercel/vercel-site/2D5Xirs9Vr1M29WHAuNawgjvgE4G https://vercel.com/vercel/vercel-site/B2aez1NNCyVvoUBTSMFy8npBKK3j Closes NEXT-2552 closes: #51298 x-ref: #62313
@ijjk If you're interested, our Next.js builds on Vercel builds consistently fail with OOM errors. When we restart the deployment without "Use existing Build Cache", the build consistently succeeds. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a reproduction of OOMs still occurring with this chunking so going to revert while we investigate further
x-ref: #51298 (comment)
Reverts #62205
Closes NEXT-2548