Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add favicon.ico for to avoid browser requests #62511

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

dongwonnn
Copy link
Contributor

@dongwonnn dongwonnn commented Feb 25, 2024

What?

To avoid the default favicon.ico request by the browser, we are adding a vercel favicon.ico to the project.
Currently, we handle exceptions for favicon.ico entering the Dynamic Route [lang] in the following manner, but in this case, favicon.ico renders the entire page.

example:app-dir-i18n-routing

export const getDictionary = async (locale: Locale) =>
  dictionaries[locale]?.() ?? dictionaries.en();

Instead of favicon.ico, the full HTML of the default language 'en' is rendered.
스크린샷 2024-02-26 오전 1 17 56

In the correct case
스크린샷 2024-02-26 오전 1 24 49

Fixes #46918

@dongwonnn dongwonnn requested review from a team as code owners February 25, 2024 16:21
@dongwonnn dongwonnn requested review from ismaelrumzan and delbaoliveira and removed request for a team February 25, 2024 16:21
@ijjk ijjk added the examples Issue/PR related to examples label Feb 25, 2024
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@ijjk
Copy link
Member

ijjk commented Feb 26, 2024

Allow CI Workflow Run

  • approve CI run for commit: 6eebf73

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Feb 26, 2024

Allow CI Workflow Run

  • approve CI run for commit: 6eebf73

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx enabled auto-merge (squash) February 26, 2024 17:27
@samcx samcx merged commit e35ace6 into vercel:canary Feb 26, 2024
30 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app-dir-i18n - TypeError: dictionaries[locale] is not a function
3 participants