Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to npm-run-all2 #62610

Closed
wants to merge 2 commits into from
Closed

chore: upgrade to npm-run-all2 #62610

wants to merge 2 commits into from

Conversation

43081j
Copy link

@43081j 43081j commented Feb 27, 2024

This upgrades from npm-run-all to npm-run-all2. Primarily because the latter is actively maintained, has security updates and a reduced footprint in the dependency tree.

This is part of a wider ecosystem cleanup in case you were curious (many packages have already been migrated for this particular dependency).

Copy link

socket-security bot commented Feb 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/npm-run-all2@6.1.2 environment, filesystem Transitive: shell +16 835 kB bret

🚮 Removed packages: npm/npm-run-all@4.1.5

View full report↗︎

This upgrades from `npm-run-all` to `npm-run-all2`. Primarily because
the latter is actively maintained, has security updates and a heavily
reduced footprint in the dependency tree.
Copy link
Contributor

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that Next.js doesn't use npm-run-all anymore. Maybe we could just remove npm-run-all entirely?

@samcx samcx closed this Feb 28, 2024
@samcx samcx reopened this Feb 28, 2024
@samcx
Copy link
Member

samcx commented Feb 28, 2024

@SukkaW Actually, it is being used with the run-p command.

@ijjk
Copy link
Member

ijjk commented Feb 28, 2024

Stats from current PR

Default Build
General
vercel/next.js canary 43081j/next.js ra2 Change
buildDuration 13.9s 13.9s N/A
buildDurationCached 8.6s 6.3s N/A
nodeModulesSize 197 MB 197 MB
nextStartRea..uration (ms) 447ms 407ms N/A
Client Bundles (main, webpack)
vercel/next.js canary 43081j/next.js ra2 Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary 43081j/next.js ra2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary 43081j/next.js ra2 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary 43081j/next.js ra2 Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary 43081j/next.js ra2 Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary 43081j/next.js ra2 Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary 43081j/next.js ra2 Change
middleware-b..fest.js gzip 625 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary 43081j/next.js ra2 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 150 kB 150 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.6 kB 50.6 kB
Overall change 950 kB 950 kB
build cache
vercel/next.js canary 43081j/next.js ra2 Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 104 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: b5e9428

@43081j
Copy link
Author

43081j commented Feb 28, 2024

exactly. the aim here is to drop npm-run-all fwiw too.

so whether you remove it, change it to another alternative, etc will still achieve the goal. not tied to the particular package

@styfle styfle closed this in 340125a Feb 28, 2024
@43081j 43081j deleted the ra2 branch February 28, 2024 16:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants