Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with-passport-and-next-connect import #62874

Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 5, 2024

What?

This example had a wrong import but somehow it still compiled with webpack. Correctly fails in Turbopack. This adjusts the import to use the package specified in package.json.

Closes NEXT-2708

@timneutkens timneutkens requested review from a team as code owners March 5, 2024 12:09
@timneutkens timneutkens requested review from ismaelrumzan and delbaoliveira and removed request for a team March 5, 2024 12:09
@ijjk ijjk added examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team. labels Mar 5, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@timneutkens timneutkens merged commit c59b391 into canary Mar 5, 2024
31 checks passed
@timneutkens timneutkens deleted the 03-05-Fix_with-passport-and-next-connect_import branch March 5, 2024 12:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants