Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge css plugin to account for css order #62927

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 6, 2024

What?

Merging css chunks need to account for css order when merging chunks

Why?

Changing the order would break css

Closes PACK-2671

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. type: next labels Mar 6, 2024
@ijjk
Copy link
Member

ijjk commented Mar 6, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
buildDuration 13.9s 13.9s N/A
buildDurationCached 7.5s 6.3s N/A
nodeModulesSize 198 MB 198 MB ⚠️ +25.2 kB
nextStartRea..uration (ms) 438ms 436ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
2453-HASH.js gzip 30.2 kB 30.2 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
index.html gzip 529 B 529 B
link.html gzip 542 B 541 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 529 B 529 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.07 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.8 kB 96.8 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 150 kB 150 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.54 kB 9.54 kB
pages-api.ru...dev.js gzip 9.81 kB 9.81 kB
pages-api.ru..prod.js gzip 9.54 kB 9.54 kB
pages-turbo...prod.js gzip 22.4 kB 22.4 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 50.6 kB 50.6 kB
Overall change 950 kB 950 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/merge-css-plugin Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 106 kB ⚠️ +519 B
Overall change 105 kB 106 kB ⚠️ +519 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 879d269

@sokra sokra marked this pull request as ready for review March 6, 2024 09:37
@sokra sokra changed the title fix merge css plugin to acount for css order fix merge css plugin to account for css order Mar 6, 2024
@timneutkens timneutkens merged commit 6194e49 into canary Mar 6, 2024
68 checks passed
@timneutkens timneutkens deleted the sokra/merge-css-plugin branch March 6, 2024 09:43
@sokra sokra mentioned this pull request Mar 6, 2024
sokra added a commit that referenced this pull request Mar 6, 2024
### What?

fixup for #62927 


Closes PACK-2672
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants