Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Authentication docs improper nesting of unordered list inside ordered list #62958

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

landoncolburn
Copy link
Contributor

On the Building Your Application: Authentication page, the formatting is broken in the "Setting Up Middleware" section because the unordered list is nested inside the ordered list. This is causing the unordered list components to be numbered and throw off the ordering of the top level list.

I made a tiny change to the markdown to make the top level steps h4 titles, and un-nested the unordered list's

Closes NEXT-61838
Fixes #61838

…ntication docs page

On the Building Your Application: Authentication page, the formatting is broken in the "Setting Up Middleware" section because the unordered list is nested inside the ordered list. This is causing the unordered list components to be numbered and throw off the ordering of the top level list.  

I made a tiny change to the markdown to make the top level steps h4 titles, and un-nested the unordered list's
@landoncolburn landoncolburn requested review from a team as code owners March 6, 2024 19:12
@landoncolburn landoncolburn requested review from ismaelrumzan and delbaoliveira and removed request for a team March 6, 2024 19:12
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@ijjk
Copy link
Member

ijjk commented Mar 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: 5261908

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx enabled auto-merge (squash) March 6, 2024 22:21
@ijjk
Copy link
Member

ijjk commented Mar 11, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary apostolos/next.js patch-2 Change
buildDuration 15.3s 15.1s N/A
buildDurationCached 9.5s 6.9s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 447ms 457ms N/A
Client Bundles (main, webpack)
vercel/next.js canary apostolos/next.js patch-2 Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary apostolos/next.js patch-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary apostolos/next.js patch-2 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary apostolos/next.js patch-2 Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary apostolos/next.js patch-2 Change
index.html gzip 528 B 529 B N/A
link.html gzip 539 B 541 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary apostolos/next.js patch-2 Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.07 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary apostolos/next.js patch-2 Change
middleware-b..fest.js gzip 627 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary apostolos/next.js patch-2 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.5 kB 96.5 kB
app-page-tur..prod.js gzip 98.3 kB 98.3 kB
app-page-tur..prod.js gzip 92.7 kB 92.7 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.2 kB 91.2 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 22.9 kB 22.9 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.5 kB 50.5 kB
Overall change 948 kB 948 kB
build cache Overall increase ⚠️
vercel/next.js canary apostolos/next.js patch-2 Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +254 B
index.pack gzip 105 kB 106 kB ⚠️ +317 B
Overall change 1.66 MB 1.66 MB ⚠️ +571 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 6d897ee

@samcx samcx merged commit cc57fe8 into vercel:canary Mar 11, 2024
28 checks passed
@landoncolburn landoncolburn deleted the patch-2 branch March 14, 2024 01:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Sub bullet point rendering incorrectly as numbered list
3 participants