Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timeout to test step and give whole job a bigger timeout #62997

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 7, 2024

Why?

Sometimes the turbo build-native command takes longer to restore stealing time from the actual test job

Closes PACK-2681

@sokra sokra requested review from a team as code owners March 7, 2024 13:41
@sokra sokra requested review from timeyoutakeit and leerob and removed request for a team March 7, 2024 13:41
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Mar 7, 2024
@ijjk
Copy link
Member

ijjk commented Mar 7, 2024

Failing test suites

Commit: ba29e53

TURBOPACK=1 pnpm test test/integration/cli/test/index.test.js (turbopack)

  • CLI Usage > dev > NODE_OPTIONS='--inspect'
Expand output

● CLI Usage › dev › NODE_OPTIONS='--inspect'

TIMED OUT: /Debugger listening on/

Starting inspector on 127.0.0.1:9229 failed: address already in use
Starting inspector on 127.0.0.1:9230 failed: address already in use


undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (integration/cli/test/index.test.js:545:9)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test-dev test/development/basic/hmr.test.ts (turbopack)

  • basic HMR, basePath: "" > should have correct compile timing after fixing error
  • basic HMR, basePath: "/docs" > should have correct compile timing after fixing error
Expand output

● basic HMR, basePath: "" › should have correct compile timing after fixing error

expect(received).toBeLessThan(expected)

Expected: < 3000
Received:   NaN

  1216 |           compileTimeMs = compileTimeMs * 1000
  1217 |         }
> 1218 |         expect(compileTimeMs).toBeLessThan(3000)
       |                               ^
  1219 |       } finally {
  1220 |         await next.patchFile(pageName, originalContent)
  1221 |       }

  at Object.toBeLessThan (development/basic/hmr.test.ts:1218:31)

● basic HMR, basePath: "/docs" › should have correct compile timing after fixing error

expect(received).toBeLessThan(expected)

Expected: < 3000
Received:   NaN

  1216 |           compileTimeMs = compileTimeMs * 1000
  1217 |         }
> 1218 |         expect(compileTimeMs).toBeLessThan(3000)
       |                               ^
  1219 |       } finally {
  1220 |         await next.patchFile(pageName, originalContent)
  1221 |       }

  at Object.toBeLessThan (development/basic/hmr.test.ts:1218:31)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Mar 7, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
buildDuration 13.6s 13.8s ⚠️ +193ms
buildDurationCached 7.4s 6.1s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 437ms 449ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.07 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
middleware-b..fest.js gzip 626 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.5 kB 96.5 kB
app-page-tur..prod.js gzip 98.2 kB 98.2 kB
app-page-tur..prod.js gzip 92.7 kB 92.7 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.2 kB 91.2 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 22.9 kB 22.9 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.5 kB 50.5 kB
Overall change 947 kB 947 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/ci-timeout Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 105 kB ⚠️ +212 B
Overall change 105 kB 105 kB ⚠️ +212 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: ba29e53

@sokra sokra merged commit c1d4450 into canary Mar 7, 2024
63 of 67 checks passed
@sokra sokra deleted the sokra/ci-timeout branch March 7, 2024 16:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants