Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken create-next-app tests #63019

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix broken create-next-app tests #63019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/run-for-change.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ const CHANGE_ITEM_GROUPS = {
'packages/next-env/README.md',
],
'deploy-examples': ['examples/image-component'],
cna: ['packages/create-next-app', 'test/integration/create-next-app'],
cna: [
'packages/create-next-app',
'test/integration/create-next-app',
'examples/basic-css',
],
'next-codemod': ['packages/next-codemod'],
'next-swc': [
'packages/next-swc',
Expand Down
12 changes: 8 additions & 4 deletions test/integration/create-next-app/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ describe('create next app', () => {
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'node_modules/next',
],
Expand Down Expand Up @@ -196,7 +197,8 @@ describe('create next app', () => {
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'node_modules/next',
],
Expand Down Expand Up @@ -260,7 +262,8 @@ describe('create next app', () => {
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'node_modules/react',
],
Expand Down Expand Up @@ -293,7 +296,8 @@ describe('create next app', () => {
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'node_modules/react',
],
Expand Down
24 changes: 16 additions & 8 deletions test/integration/create-next-app/package-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ it('should use npm as the package manager on supplying --use-npm with example',
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'package-lock.json',
'node_modules/next',
Expand Down Expand Up @@ -168,7 +169,8 @@ it('should use Yarn as the package manager on supplying --use-yarn with example'
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'yarn.lock',
'node_modules/next',
Expand Down Expand Up @@ -246,7 +248,8 @@ it('should use pnpm as the package manager on supplying --use-pnpm with example'
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'pnpm-lock.yaml',
'node_modules/next',
Expand Down Expand Up @@ -320,7 +323,8 @@ it('should use Bun as the package manager on supplying --use-bun with example',
projectName,
files: [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'bun.lockb',
'node_modules/next',
Expand Down Expand Up @@ -379,7 +383,8 @@ it('should infer npm as the package manager with example', async () => {

const files = [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'package-lock.json',
'node_modules/next',
Expand Down Expand Up @@ -462,7 +467,8 @@ it('should infer yarn as the package manager with example', async () => {

const files = [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'yarn.lock',
'node_modules/next',
Expand Down Expand Up @@ -545,7 +551,8 @@ it('should infer pnpm as the package manager with example', async () => {

const files = [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'pnpm-lock.yaml',
'node_modules/next',
Expand Down Expand Up @@ -620,7 +627,8 @@ it('should infer Bun as the package manager with example', async () => {

const files = [
'package.json',
'pages/index.tsx',
'app/page.tsx',
'app/layout.tsx',
'.gitignore',
'bun.lockb',
'node_modules/next',
Expand Down