fix dynamic api route test

[ztanner]

While looking at flakey tests I noticed that this test has a typo which means the assertion was being skipped all together.

Closes NEXT-2760

[ztanner]

• fix dynamic api route test #63027 👈
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite

[samcx]

[ijjk]

Failing test suites

Commit: d0a9841

TURBOPACK=1 pnpm test test/integration/cli/test/index.test.js (turbopack)

• CLI Usage > dev > NODE_OPTIONS='--inspect'

Expand output

● CLI Usage › dev › NODE_OPTIONS='--inspect'

TIMED OUT: /Debugger listening on/

Starting inspector on 127.0.0.1:9229 failed: address already in use
Starting inspector on 127.0.0.1:9230 failed: address already in use


undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (integration/cli/test/index.test.js:545:9)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/app-dir-export/test/dynamicapiroute-prod.test.ts

• app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicApiRoute 'error'
• app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicApiRoute 'force-static'
• app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicApiRoute 'force-dynamic'

Expand output

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicApiRoute 'error'

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  12 |           'export const dynamic = "force-dynamic" on page "/api/json" cannot be used with "output: export".',
  13 |       },
> 14 |     ])(
     |      ^
  15 |       'should work in prod with dynamicApiRoute $dynamicApiRoute',
  16 |       async ({ dynamicApiRoute, expectedErrMsg }) => {
  17 |         await runTests({ isDev: false, dynamicApiRoute, expectedErrMsg })

  at ../node_modules/.pnpm/jest-each@29.7.0/node_modules/jest-each/build/bind.js:47:15
      at Array.forEach (<anonymous>)
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:14:6
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:4:52
  at Object.describe (integration/app-dir-export/test/dynamicapiroute-prod.test.ts:3:1)

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicApiRoute 'force-static'

Failed to replace content.

Pattern: const dynamic = 'force-static'

Content: export const dynamic = 'error'

export async function GET() {
  return Response.json({ answer: 42 })
}

  669 |     } else if (typeof pattern === 'string') {
  670 |       if (!currentContent.includes(pattern)) {
> 671 |         throw new Error(
      |               ^
  672 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  673 |         )
  674 |       }

  at File.replace (lib/next-test-utils.ts:671:15)
  at replace (integration/app-dir-export/test/utils.ts:118:13)
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:17:23

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicApiRoute 'force-dynamic'

Failed to replace content.

Pattern: const dynamic = 'force-static'

Content: export const dynamic = 'error'

export async function GET() {
  return Response.json({ answer: 42 })
}

  669 |     } else if (typeof pattern === 'string') {
  670 |       if (!currentContent.includes(pattern)) {
> 671 |         throw new Error(
      |               ^
  672 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  673 |         )
  674 |       }

  at File.replace (lib/next-test-utils.ts:671:15)
  at replace (integration/app-dir-export/test/utils.ts:118:13)
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:17:23

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
buildDuration	13.7s	13.7s	N/A
buildDurationCached	7.4s	6.2s	N/A
nodeModulesSize	198 MB	198 MB	✓
nextStartRea..uration (ms)	431ms	436ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
2453-HASH.js gzip	30.5 kB	30.5 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	N/A
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	241 B	N/A
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	45.4 kB	45.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
index.html gzip	529 B	528 B	N/A
link.html gzip	541 B	542 B	N/A
withRouter.html gzip	524 B	524 B	✓
Overall change	524 B	524 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
edge-ssr.js gzip	95.1 kB	95.1 kB	N/A
page.js gzip	3.07 kB	3.07 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
middleware-b..fest.js gzip	625 B	625 B	✓
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	1.61 kB	1.61 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	96.5 kB	96.5 kB	✓
app-page-tur..prod.js gzip	98.2 kB	98.2 kB	✓
app-page-tur..prod.js gzip	92.7 kB	92.7 kB	✓
app-page.run...dev.js gzip	149 kB	149 kB	✓
app-page.run..prod.js gzip	91.2 kB	91.2 kB	✓
app-route-ex...dev.js gzip	21.3 kB	21.3 kB	✓
app-route-ex..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	20.9 kB	20.9 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.52 kB	9.52 kB	✓
pages-api.ru...dev.js gzip	9.8 kB	9.8 kB	✓
pages-api.ru..prod.js gzip	9.52 kB	9.52 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	22.9 kB	22.9 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.5 kB	50.5 kB	✓
Overall change	947 kB	947 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 03-07-fix_dynamic_api_route_test	Change
0.pack gzip	1.56 MB	1.56 MB	⚠️ +460 B
index.pack gzip	105 kB	106 kB	N/A
Overall change	1.56 MB	1.56 MB	⚠️ +460 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: 40dbc3a