Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): dynamically update page title #63110

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

caseyocampo
Copy link
Contributor

What?

blog-starter-kit's page title does not update when navigating to a blog post.

Why?

The title property was missing from:

return {
    title, // missing
    openGraph: {
      title,
      images: [post.ogImage.url],
    },
  };

Closes NEXT-Page title is not dynamically updating #63083

Fixes #63083

@caseyocampo caseyocampo requested review from a team as code owners March 10, 2024 15:28
@caseyocampo caseyocampo requested review from delbaoliveira and StephDietz and removed request for a team March 10, 2024 15:28
@ijjk ijjk added the examples Issue/PR related to examples label Mar 10, 2024
@ijjk
Copy link
Member

ijjk commented Mar 10, 2024

Allow CI Workflow Run

  • approve CI run for commit: e7d54fa

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx enabled auto-merge (squash) March 10, 2024 23:18
@samcx
Copy link
Member

samcx commented Mar 11, 2024

@caseyocampo No need to merge canary again—it'll require somebody on the team to approve your commit again so the CI runs.

@samcx samcx self-requested a review March 11, 2024 15:42
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx merged commit 44626ed into vercel:canary Mar 11, 2024
28 checks passed
@caseyocampo caseyocampo deleted the fix-page-title-not-updating branch March 11, 2024 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page title is not dynamically updating
3 participants