Remove minimal env var from define-env-plugin

[timneutkens]

What?

Checking to see if this breaks any tests.

Closes NEXT-2772

[timneutkens]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Remove minimal env var from define-env-plugin #63137 👈
• Refactor define-env-plugin to have stricter types #63128
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
buildDuration	13.8s	14.2s	⚠️ +316ms
buildDurationCached	7.4s	6.2s	N/A
nodeModulesSize	198 MB	198 MB	N/A
nextStartRea..uration (ms)	431ms	451ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
2453-HASH.js gzip	30.5 kB	30.5 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	N/A
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	45.4 kB	45.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
index.html gzip	528 B	529 B	N/A
link.html gzip	539 B	541 B	N/A
withRouter.html gzip	523 B	523 B	✓
Overall change	523 B	523 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
edge-ssr.js gzip	95.1 kB	95.1 kB	N/A
page.js gzip	3.06 kB	3.07 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
middleware-b..fest.js gzip	627 B	625 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	96.5 kB	96.5 kB	✓
app-page-tur..prod.js gzip	98.3 kB	98.3 kB	✓
app-page-tur..prod.js gzip	92.7 kB	92.7 kB	✓
app-page.run...dev.js gzip	149 kB	149 kB	✓
app-page.run..prod.js gzip	91.2 kB	91.2 kB	✓
app-route-ex...dev.js gzip	21.3 kB	21.3 kB	✓
app-route-ex..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	21 kB	21 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.52 kB	9.52 kB	✓
pages-api.ru...dev.js gzip	9.8 kB	9.8 kB	✓
pages-api.ru..prod.js gzip	9.52 kB	9.52 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	22.9 kB	22.9 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.5 kB	50.5 kB	✓
Overall change	948 kB	948 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 03-11-Remove_minimal_env_var_from_define-env-plugin	Change
0.pack gzip	1.56 MB	1.56 MB	N/A
index.pack gzip	105 kB	105 kB	⚠️ +411 B
Overall change	105 kB	105 kB	⚠️ +411 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: 47b265e

[ijjk]

Failing test suites

Commit: 47b265e

TURBOPACK=1 pnpm test-dev test/development/tsconfig-path-reloading/index.test.ts (turbopack)

• tsconfig-path-reloading > tsconfig added after starting dev > should recover from module not found when paths is updated

Expand output

● tsconfig-path-reloading › tsconfig added after starting dev › should recover from module not found when paths is updated

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script src="/_next/static/chunks/%5Broot%20of%20the%20server%5D__1e0779._.js" defer=""></script><script src="/_next/static/chunks/c8460_react_22c55a._.js" defer=""></script><script src="/_next/static/chunks/4e99c_react-dom_cjs_react-dom_development_c0b264.js" defer=""></script><script src="/_next/static/chunks/4e99c_react-dom_55c180._.js" defer=""></script><script src="/_next/static/chunks/node_modules__pnpm_762be9._.js" defer=""></script><script src="/_next/static/chunks/%5Bturbopack%5D_dev_client_38d6c6._.js" defer=""></script><script src="/_next/static/chunks/8fc59_next_dist_pages_a5f5da._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_d6e219._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_26467f._.js" defer=""></script><script src="/_next/static/chunks/%5Broot%20of%20the%20server%5D__040f08._.js" defer=""></script><script src="/_next/static/chunks/8fc59_next_dist_pages_7312e0._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_f43245._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_ca20d4._.js" defer=""></script><script src="/_next/static/development/_ssgManifest.js" defer=""></script><script src="/_next/static/development/_buildManifest.js" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body style="overflow: hidden;"><div id="__next"></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{"statusCode":500}},"page":"/_error","query":{},"buildId":"development","isFallback":false,"err":{"name":"Error","source":"server","message":"./pages/index.tsx:1:1\nModule not found: Can't resolve '@c/button-1'\n\u003e 1 | import { Button1 } from '@c/button-1'\n    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  2 | import { Button2 } from '@mybutton'\n  3 | import { firstData } from '@lib/first-data'\n  4 |\n\nhttps://nextjs.org/docs/messages/module-not-found\n\n","stack":"Error: ./pages/index.tsx:1:1\nModule not found: Can't resolve '@c/button-1'\n\u001b[0m\u001b[31m\u001b[1m\u003e\u001b[22m\u001b[39m\u001b[90m 1 |\u001b[39m \u001b[36mimport\u001b[39m { \u001b[33mButton1\u001b[39m } \u001b[36mfrom\u001b[39m \u001b[32m'@c/button-1'\u001b[39m\u001b[0m\n\u001b[0m \u001b[90m   |\u001b[39m \u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[31m\u001b[1m^\u001b[22m\u001b[39m\u001b[0m\n\u001b[0m \u001b[90m 2 |\u001b[39m \u001b[36mimport\u001b[39m { \u001b[33mButton2\u001b[39m } \u001b[36mfrom\u001b[39m \u001b[32m'@mybutton'\u001b[39m\u001b[0m\n\u001b[0m \u001b[90m 3 |\u001b[39m \u001b[36mimport\u001b[39m { firstData } \u001b[36mfrom\u001b[39m \u001b[32m'@lib/first-data'\u001b[39m\u001b[0m\n\u001b[0m \u001b[90m 4 |\u001b[39m\u001b[0m\n\nhttps://nextjs.org/docs/messages/module-not-found\n\n\n    at Object.getCompilationErrors (/tmp/next-install-b12342261b1773afba0c17442038c4072386d959d7ca7382a54e005d46e6a40e/node_modules/.pnpm/file+..+next-repo-fbf9feb6fba72e4384a53efb766c7c8a5c9037f9e7baae3fe94615937b1b477c+packages+n_f6jowtaz55gp7v6wv6uv4toh4u/node_modules/next/dist/server/dev/hot-reloader-turbopack.js:544:33)\n    at DevBundlerService.getCompilationError (/tmp/next-install-b12342261b1773afba0c17442038c4072386d959d7ca7382a54e005d46e6a40e/node_modules/.pnpm/file+..+next-repo-fbf9feb6fba72e4384a53efb766c7c8a5c9037f9e7baae3fe94615937b1b477c+packages+n_f6jowtaz55gp7v6wv6uv4toh4u/node_modules/next/dist/server/lib/dev-bundler-service.js:36:55)\n    at DevServer.getCompilationError (/tmp/next-install-b12342261b1773afba0c17442038c4072386d959d7ca7382a54e005d46e6a40e/node_modules/.pnpm/file+..+next-repo-fbf9feb6fba72e4384a53efb766c7c8a5c9037f9e7baae3fe94615937b1b477c+packages+n_f6jowtaz55gp7v6wv6uv4toh4u/node_modules/next/dist/server/dev/next-dev-server.js:597:42)\n    at DevServer.findPageComponents (/tmp/next-install-b12342261b1773afba0c17442038c4072386d959d7ca7382a54e005d46e6a40e/node_modules/.pnpm/file+..+next-repo-fbf9feb6fba72e4384a53efb766c7c8a5c9037f9e7baae3fe94615937b1b477c+packages+n_f6jowtaz55gp7v6wv6uv4toh4u/node_modules/next/dist/server/dev/next-dev-server.js:556:43)\n    at async DevServer.renderErrorToResponseImpl (/tmp/next-install-b12342261b1773afba0c17442038c4072386d959d7ca7382a54e005d46e6a40e/node_modules/.pnpm/file+..+next-repo-fbf9feb6fba72e4384a53efb766c7c8a5c9037f9e7baae3fe94615937b1b477c+packages+n_f6jowtaz55gp7v6wv6uv4toh4u/node_modules/next/dist/server/base-server.js:2107:26)"},"gip":true,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; top: 0px; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer><nextjs-portal></nextjs-portal></body>

undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (development/tsconfig-path-reloading/index.test.ts:117:9)

Read more about building and testing Next.js in contributing.md.