-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure undefined values end up being replaced #63138
Merged
timneutkens
merged 4 commits into
canary
from
03-11-Ensure_undefined_values_end_up_being_replaced
Mar 12, 2024
Merged
Ensure undefined values end up being replaced #63138
timneutkens
merged 4 commits into
canary
from
03-11-Ensure_undefined_values_end_up_being_replaced
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
ztanner,
feedthejim and
a team
as code owners
March 11, 2024 13:38
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on Graphite |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display Diff for main-HASH.jsDiff too large to display |
timneutkens
force-pushed
the
03-11-Ensure_undefined_values_end_up_being_replaced
branch
from
March 12, 2024 12:57
bacd45a
to
a36fbab
Compare
ForsakenHarmony
approved these changes
Mar 12, 2024
timneutkens
deleted the
03-11-Ensure_undefined_values_end_up_being_replaced
branch
March 12, 2024 15:04
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #63128
JSON.stringify(undefined)
ends up with the valueundefined
. However for Webpack/Turbopack to correctly injectundefined
into the code it has to be the string'undefined'
. This change ensures the serialization takes into account that case.Closes NEXT-2773