-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip worker test in Turbopack #63398
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on Graphite |
Failing test suitesCommit: 86646db
Expand output● Custom _error › dev mode 2 › should not warn with /_error and /404
Read more about building and testing Next.js in contributing.md.
Expand output● AMP Usage › production mode › should have amp optimizer in trace
● AMP Usage › production mode › With basic usage › should render the page
● AMP Usage › production mode › With basic AMP usage › should render the page as valid AMP
● AMP Usage › production mode › With basic AMP usage › should render the page without leaving render target
● AMP Usage › production mode › With basic AMP usage › should not output client pages for AMP only
● AMP Usage › production mode › With basic AMP usage › should not output client pages for AMP only with config exported after declaration
● AMP Usage › production mode › With basic AMP usage › should drop custom scripts
● AMP Usage › production mode › With basic AMP usage › should not drop custom amp scripts
● AMP Usage › production mode › With basic AMP usage › should optimize clean
● AMP Usage › production mode › With basic AMP usage › should auto import extensions
● AMP Usage › production mode › With AMP context › should render the normal page that uses the AMP hook
● AMP Usage › production mode › With AMP context › should render the AMP page that uses the AMP hook
● AMP Usage › production mode › With AMP context › should render nested normal page with AMP hook
● AMP Usage › production mode › With AMP context › should render nested AMP page with AMP hook
● AMP Usage › production mode › canonical amphtml › should render link rel amphtml
● AMP Usage › production mode › canonical amphtml › should render amphtml from provided rel link
● AMP Usage › production mode › canonical amphtml › should render link rel amphtml with existing query
● AMP Usage › production mode › canonical amphtml › should render the AMP page that uses the AMP hook
● AMP Usage › production mode › canonical amphtml › should render a canonical regardless of amp-only status (explicit)
● AMP Usage › production mode › canonical amphtml › should not render amphtml link tag with no AMP page
● AMP Usage › production mode › canonical amphtml › should remove conflicting amp tags
● AMP Usage › production mode › canonical amphtml › should allow manually setting canonical
● AMP Usage › production mode › canonical amphtml › should allow manually setting amphtml rel
● AMP Usage › production mode › combined styles › should combine style tags
● AMP Usage › production mode › combined styles › should remove sourceMaps from styles
Read more about building and testing Next.js in contributing.md.
Expand output● i18n Support › with localeDetection disabled › production mode › should have localeDetection in routes-manifest
● i18n Support › with localeDetection disabled › production mode › should not detect locale from accept-language
● i18n Support › with localeDetection disabled › production mode › should ignore the invalid accept-language header
● i18n Support › with localeDetection disabled › production mode › should set locale from detected path
Read more about building and testing Next.js in contributing.md.
Expand output● Prerender › should handle fallback only page correctly HTML
● Prerender › should not error when rewriting to fallback dynamic SSG page
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
buildDuration | 14.1s | 14s | N/A |
buildDurationCached | 7.6s | 6.4s | N/A |
nodeModulesSize | 198 MB | 198 MB | ✓ |
nextStartRea..uration (ms) | 436ms | 438ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
2453-HASH.js gzip | 30.5 kB | 30.5 kB | N/A |
3304.HASH.js gzip | 181 B | 181 B | ✓ |
3f784ff6-HASH.js gzip | 53.7 kB | 53.7 kB | N/A |
8299-HASH.js gzip | 5.04 kB | 5.04 kB | N/A |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 242 B | 242 B | ✓ |
main-HASH.js gzip | 32.2 kB | 32.2 kB | N/A |
webpack-HASH.js gzip | 1.68 kB | 1.68 kB | N/A |
Overall change | 45.6 kB | 45.6 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
_app-HASH.js gzip | 196 B | 197 B | N/A |
_error-HASH.js gzip | 184 B | 184 B | ✓ |
amp-HASH.js gzip | 505 B | 505 B | ✓ |
css-HASH.js gzip | 324 B | 325 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | N/A |
edge-ssr-HASH.js gzip | 258 B | 258 B | ✓ |
head-HASH.js gzip | 352 B | 352 B | ✓ |
hooks-HASH.js gzip | 370 B | 371 B | N/A |
image-HASH.js gzip | 4.21 kB | 4.21 kB | ✓ |
index-HASH.js gzip | 259 B | 259 B | ✓ |
link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 314 B | 312 B | N/A |
script-HASH.js gzip | 386 B | 386 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 6.57 kB | 6.57 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
_buildManifest.js gzip | 481 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
index.html gzip | 529 B | 528 B | N/A |
link.html gzip | 540 B | 541 B | N/A |
withRouter.html gzip | 523 B | 523 B | ✓ |
Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
edge-ssr.js gzip | 95.1 kB | 95.1 kB | N/A |
page.js gzip | 3.05 kB | 3.05 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 624 B | 624 B | ✓ |
middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
middleware.js gzip | 25.5 kB | 25.5 kB | N/A |
edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
Overall change | 1.61 kB | 1.61 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 171 kB | 171 kB | ✓ |
app-page-exp..prod.js gzip | 96.6 kB | 96.6 kB | ✓ |
app-page-tur..prod.js gzip | 98.3 kB | 98.3 kB | ✓ |
app-page-tur..prod.js gzip | 92.8 kB | 92.8 kB | ✓ |
app-page.run...dev.js gzip | 149 kB | 149 kB | ✓ |
app-page.run..prod.js gzip | 91.3 kB | 91.3 kB | ✓ |
app-route-ex...dev.js gzip | 21.3 kB | 21.3 kB | ✓ |
app-route-ex..prod.js gzip | 15 kB | 15 kB | ✓ |
app-route-tu..prod.js gzip | 15 kB | 15 kB | ✓ |
app-route-tu..prod.js gzip | 14.8 kB | 14.8 kB | ✓ |
app-route.ru...dev.js gzip | 21 kB | 21 kB | ✓ |
app-route.ru..prod.js gzip | 14.8 kB | 14.8 kB | ✓ |
pages-api-tu..prod.js gzip | 9.52 kB | 9.52 kB | ✓ |
pages-api.ru...dev.js gzip | 9.8 kB | 9.8 kB | ✓ |
pages-api.ru..prod.js gzip | 9.52 kB | 9.52 kB | ✓ |
pages-turbo...prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
pages.runtim...dev.js gzip | 22.9 kB | 22.9 kB | ✓ |
pages.runtim..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
server.runti..prod.js gzip | 50.6 kB | 50.6 kB | ✓ |
Overall change | 948 kB | 948 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 03-18-Skip_worker_test_in_Turbopack | Change | |
---|---|---|---|
0.pack gzip | 1.56 MB | 1.56 MB | N/A |
index.pack gzip | 105 kB | 106 kB | |
Overall change | 105 kB | 106 kB |
Diff details
Diff for middleware.js
Diff too large to display
What?
new Worker()
is not supported yet in Turbopack. Support for it will be added after stable.Closes NEXT-2831