Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for SCSS mixin that uses parenthesis #63562

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 21, 2024

What?

Adds a test for a reported problem where sass-loader fails with Null check operator used on a null value.

Bugfix is in vercel/turborepo#7800

Closes NEXT-2889

Copy link
Member Author

timneutkens commented Mar 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@timneutkens timneutkens marked this pull request as draft March 21, 2024 13:08
@ijjk
Copy link
Member

ijjk commented Mar 21, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
buildDuration 13.9s 13.7s N/A
buildDurationCached 8.4s 6.2s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 434ms 429ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
2453-HASH.js gzip 30.8 kB 30.8 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
index.html gzip 530 B 529 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
middleware-b..fest.js gzip 626 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 98.6 kB 98.6 kB
app-page-tur..prod.js gzip 93.1 kB 93.1 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.54 kB 9.54 kB
pages-api.ru...dev.js gzip 9.81 kB 9.81 kB
pages-api.ru..prod.js gzip 9.54 kB 9.54 kB
pages-turbo...prod.js gzip 22.4 kB 22.4 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 50.9 kB 50.9 kB
Overall change 945 kB 945 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis Change
0.pack gzip 1.57 MB 1.57 MB N/A
index.pack gzip 105 kB 106 kB ⚠️ +316 B
Overall change 105 kB 106 kB ⚠️ +316 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 00b303a

@timneutkens timneutkens force-pushed the 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis branch from 1ad2682 to 00b303a Compare March 22, 2024 09:24
@timneutkens timneutkens marked this pull request as ready for review March 22, 2024 09:34
@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Tests Passed

@timneutkens timneutkens enabled auto-merge (squash) March 22, 2024 09:34
@timneutkens timneutkens merged commit 0234afa into canary Mar 22, 2024
77 checks passed
@timneutkens timneutkens deleted the 03-21-Add_failing_test_for_SCSS_mixin_that_uses_parenthesis branch March 22, 2024 10:24
@github-actions github-actions bot added the locked label Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants