Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-overlay): align codeframe to formatIssue #63624

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 22, 2024

Closes PACK-2825

@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Tests Passed

@kwonoj kwonoj closed this Mar 22, 2024
@kwonoj kwonoj deleted the source-issue-imports-error branch March 22, 2024 22:16
@kwonoj kwonoj restored the source-issue-imports-error branch March 22, 2024 22:16
@kwonoj kwonoj reopened this Mar 22, 2024
@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js source-issue-imports-error Change
buildDuration 13.8s 13.7s N/A
buildDurationCached 7.4s 6.2s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 434ms 438ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js source-issue-imports-error Change
2453-HASH.js gzip 30.8 kB 30.8 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js source-issue-imports-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js source-issue-imports-error Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js source-issue-imports-error Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js source-issue-imports-error Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 523 B 523 B
Overall change 1.59 kB 1.59 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js source-issue-imports-error Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js source-issue-imports-error Change
middleware-b..fest.js gzip 624 B 627 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js source-issue-imports-error Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.8 kB 96.8 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.8 kB 92.8 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.3 kB 91.3 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 50.9 kB 50.9 kB
Overall change 943 kB 943 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js source-issue-imports-error Change
0.pack gzip 1.57 MB 1.57 MB ⚠️ +494 B
index.pack gzip 106 kB 106 kB ⚠️ +502 B
Overall change 1.67 MB 1.67 MB ⚠️ +996 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 6225397

@kwonoj kwonoj force-pushed the source-issue-imports-error branch 2 times, most recently from e6dfab1 to 2e334b6 Compare March 22, 2024 23:32
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Mar 22, 2024
@kwonoj kwonoj force-pushed the source-issue-imports-error branch from 2e334b6 to ef2deb4 Compare March 22, 2024 23:54
@kwonoj kwonoj force-pushed the source-issue-imports-error branch 3 times, most recently from b0da2a3 to 64b289f Compare March 23, 2024 00:29
kwonoj added a commit to vercel/turborepo that referenced this pull request Mar 24, 2024
### Description

While debugging
https://vercel.slack.com/archives/C03EWR7LGEN/p1711146825831219?thread_ts=1711143217.892349&cid=C03EWR7LGEN,
found out sourcemap lookup fails on certain source and always returns
synthetictoken only.

Weirdly, the guards in this PR
https://github.com/vercel/turbo/pull/7823/files#diff-2ce67e28c5b3144ec6f7a89167f3c96da9f9e268abf3fd685ce881d75a4cd8a5L319
is preventing those lookup - removing it makes correct sourcemap lookup
occurs. I updated pkg to the version what swc uses and removed + ran
next.js tests, seems like most of tests are running just fine

(vercel/next.js#63624)

Still not 100% sure if this'll be ok or not, if not open to change for
the correct fixes. Some related fixes
getsentry/rust-sourcemap#60 might be the reason
we don't see any regressions in the test.
@kwonoj kwonoj force-pushed the source-issue-imports-error branch from 64b289f to 6225397 Compare March 25, 2024 16:06
@kwonoj kwonoj marked this pull request as ready for review March 25, 2024 16:38
@kwonoj kwonoj requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners March 25, 2024 16:38
@kwonoj kwonoj merged commit 35f93e3 into canary Mar 25, 2024
77 checks passed
@kwonoj kwonoj deleted the source-issue-imports-error branch March 25, 2024 16:55
@github-actions github-actions bot added the locked label Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants