Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Update Turbopack production test manifest"" #63700

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 26, 2024

Relanding this PR after investigating why the test/integration tests were running.

Reverts #63688

Closes NEXT-2927

@ijjk
Copy link
Member

ijjk commented Mar 26, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
buildDuration 14s 13.9s N/A
buildDurationCached 8.5s 6.3s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 406ms 401ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
2453-HASH.js gzip 30.8 kB 30.8 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.8 kB 96.8 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.8 kB 92.8 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.3 kB 91.3 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 50.9 kB 50.9 kB
Overall change 943 kB 943 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-63699-revert-63688-update/turbopack-manifest-1711403028265 Change
0.pack gzip 1.57 MB 1.57 MB ⚠️ +191 B
index.pack gzip 106 kB 106 kB ⚠️ +189 B
Overall change 1.67 MB 1.67 MB ⚠️ +380 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 347527d

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Mar 26, 2024

Failing test suites

Commit: 10b808b

TURBOPACK=1 pnpm test-start test/production/bfcache-routing/index.test.ts (turbopack)

  • bfcache-routing > should not suspend indefinitely when page is restored from bfcache after an mpa navigation
Expand output

● bfcache-routing › should not suspend indefinitely when page is restored from bfcache after an mpa navigation

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  13 |   let app: Server
  14 |
> 15 |   beforeAll(async () => {
     |   ^
  16 |     const appDir = __dirname
  17 |     const exportDir = join(appDir, 'out')
  18 |

  at beforeAll (production/bfcache-routing/index.test.ts:15:3)
  at Object.describe (production/bfcache-routing/index.test.ts:11:1)

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens merged commit 40fbede into canary Mar 26, 2024
12 of 17 checks passed
@timneutkens timneutkens deleted the revert-63699-revert-63688-update/turbopack-manifest-1711403028265 branch March 26, 2024 09:22
@github-actions github-actions bot added the locked label Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants