Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore(examples): migrate mdx from pages router (JS) to app router (TS)" #63704

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Revert "chore(examples): migrate mdx from pages router (JS) to app router (TS)" #63704

merged 1 commit into from
Mar 26, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 26, 2024 •
edited by padmaia
Loading

Reverts #63646

The example changes are missing a bunch of stuff:

  • Types are not added, you can see the changes required here: Fix MDX test #63703
  • Dependencies are missing, i.e. @types/react @types/node, typescript are all missing.

Reverting as CI is broken.

Closes NEXT-2929

@timneutkens timneutkens requested review from a team as code owners March 26, 2024 09:18
@timneutkens timneutkens requested review from manovotny and leerob and removed request for a team March 26, 2024 09:18
@ijjk ijjk added examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team. labels Mar 26, 2024
@timneutkens timneutkens merged commit 9114446 into canary Mar 26, 2024
8 checks passed
@timneutkens timneutkens deleted the revert-63646-upgrade-example branch March 26, 2024 09:18
@github-actions github-actions bot added the locked label Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manovotny manovotny Awaiting requested review from manovotny manovotny was automatically assigned from vercel/devex

@leerob leerob Awaiting requested review from leerob leerob was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk