fix(next-typescript-plugin): allow call expression for server actions

[devjiwonchoi]

cc @shuding

Why?

The typescript plugin in #63667 does not target the call expression or assigned actions.

'use server'

function action() {
  return async function() {
    return 'foo'
  }
}

async function action2() {
  return 'foo'
}

export const callAction = action() // call expression
export const assignedAction = action2 // assigned

Current

Fixed

x-ref: #63667
Closes #63743

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 649c306

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[shuding]

Thanks!

[devjiwonchoi]

Thank you for reviewing!

[ijjk]

Failing test suites

Commit: f0a315f

pnpm test-dev test/e2e/app-dir/metadata/metadata.test.ts (PPR)

• app dir - metadata > react cache > should have same title and page value when navigating

Expand output

● app dir - metadata › react cache › should have same title and page value when navigating

expect(received).toBe(expected) // Object.is equality

Expected: "0.6470844164215845"
Received: "0.5692508773302181"

  1003 |         const obj = JSON.parse(title)
  1004 |         // Check `cache()`
> 1005 |         expect(obj.val.toString()).toBe(value)
       |                                    ^
  1006 |         // Check `fetch()`
  1007 |         // TODO-APP: Investigate why fetch deduping doesn't apply but cache() does.
  1008 |         if (!isNextDev) {

  at Object.toBe (e2e/app-dir/metadata/metadata.test.ts:1005:36)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
buildDuration	14.1s	14.3s	⚠️ +193ms
buildDurationCached	8.7s	6.5s	N/A
nodeModulesSize	199 MB	199 MB	⚠️ +728 B
nextStartRea..uration (ms)	403ms	405ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
2453-HASH.js gzip	31.4 kB	31.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	242 B	✓
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99.3 kB	99.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
index.html gzip	530 B	529 B	N/A
link.html gzip	542 B	542 B	✓
withRouter.html gzip	524 B	523 B	N/A
Overall change	542 B	542 B	✓

Edge SSR bundle Size

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
edge-ssr.js gzip	95.3 kB	95.3 kB	N/A
page.js gzip	3.04 kB	3.04 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
middleware-b..fest.js gzip	626 B	627 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
app-page-exp...dev.js gzip	170 kB	170 kB	✓
app-page-exp..prod.js gzip	97 kB	97 kB	✓
app-page-tur..prod.js gzip	98.8 kB	98.8 kB	✓
app-page-tur..prod.js gzip	93 kB	93 kB	✓
app-page.run...dev.js gzip	144 kB	144 kB	✓
app-page.run..prod.js gzip	91.5 kB	91.5 kB	✓
app-route-ex...dev.js gzip	21.4 kB	21.4 kB	✓
app-route-ex..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	21 kB	21 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	22.5 kB	22.5 kB	✓
pages.runtim...dev.js gzip	23.1 kB	23.1 kB	✓
pages.runtim..prod.js gzip	22.4 kB	22.4 kB	✓
server.runti..prod.js gzip	51 kB	51 kB	✓
Overall change	944 kB	944 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	devjiwonchoi/next.js fix/ts-plugin-server-actions	Change
0.pack gzip	1.58 MB	1.58 MB	⚠️ +1.22 kB
index.pack gzip	106 kB	106 kB	⚠️ +393 B
Overall change	1.68 MB	1.68 MB	⚠️ +1.61 kB

Diff details

Diff for middleware.js

Diff too large to display

Commit: f0a315f