Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replaced more impactful words #63835

Merged
merged 5 commits into from
Apr 5, 2024
Merged

chore: Replaced more impactful words #63835

merged 5 commits into from
Apr 5, 2024

Conversation

Pyr33x
Copy link
Contributor

@Pyr33x Pyr33x commented Mar 28, 2024

That's it, and about the metadata (description), I had to change it cause it feels like the new change can be more relatable on the MDX page.

@Pyr33x Pyr33x requested review from a team as code owners March 28, 2024 17:54
@Pyr33x Pyr33x requested review from timeyoutakeit and molebox and removed request for a team March 28, 2024 17:54
@Pyr33x Pyr33x changed the title chore: Replaced some more impactful words chore: Replaced more impactful words Mar 28, 2024
@Pyr33x Pyr33x requested a review from samcx April 5, 2024 19:44
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx samcx enabled auto-merge (squash) April 5, 2024 19:45
@samcx samcx added CI approved Approve running CI for fork and removed CI approved Approve running CI for fork labels Apr 5, 2024
auto-merge was automatically disabled April 5, 2024 19:54

Head branch was pushed to by a user without write access

@samcx
Copy link
Member

samcx commented Apr 5, 2024

@Pyr33x Prettier being so weird here :lol:

@Pyr33x
Copy link
Contributor Author

Pyr33x commented Apr 5, 2024

@samcx I faced and prettier-check issue, I resolved it.

@Pyr33x
Copy link
Contributor Author

Pyr33x commented Apr 5, 2024

@Pyr33x Prettier being so weird here :lol:

Damn lol

@samcx
Copy link
Member

samcx commented Apr 5, 2024

@Pyr33x This isn't the write prettier config that's being used, it should not include ; — I'll add it myself

@Pyr33x
Copy link
Contributor Author

Pyr33x commented Apr 5, 2024

@Pyr33x This isn't the write prettier config that's being used, it should not include ; — I'll add it myself

Oh my bad, alright.

@samcx samcx enabled auto-merge (squash) April 5, 2024 20:02
@samcx samcx merged commit a1e5d0b into vercel:canary Apr 5, 2024
32 checks passed
@Pyr33x
Copy link
Contributor Author

Pyr33x commented Apr 5, 2024

Thank you 🙏🏻

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants